mbox series

[V8,0/6] Add device-tree support for Cypress CYPD4226

Message ID 20230125204211.63680-1-jonathanh@nvidia.com
Headers show
Series Add device-tree support for Cypress CYPD4226 | expand

Message

Jon Hunter Jan. 25, 2023, 8:42 p.m. UTC 
Add device-tree support for Cypress CYPD4226 Type-C controller and
enable for the Jetson AGX Orin board. This series is derived from the
series to enable USB host and device support for Jetson AGX Orin [0].
I have split this out from that series because it was getting quite
big.

[0] https://lore.kernel.org/linux-tegra/20221114124053.1873316-1-waynec@nvidia.com/

Jon Hunter (2):
  arm64: tegra: Populate USB Type-C Controller for Jetson AGX Orin
  arm64: defconfig: Enable UCSI support

Wayne Chang (4):
  dt-bindings: usb: Add Cypress cypd4226 Type-C controller
  i2c: nvidia-gpu: Add ACPI property to align with device-tree
  usb: typec: ucsi_ccg: Add OF support
  i2c: nvidia-gpu: Remove ccgx,firmware-build property

 .../bindings/usb/cypress,cypd4226.yaml        | 86 +++++++++++++++++++
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 14 +++
 arch/arm64/configs/defconfig                  |  2 +
 drivers/i2c/busses/i2c-nvidia-gpu.c           |  4 +-
 drivers/usb/typec/ucsi/ucsi_ccg.c             | 22 ++++-
 5 files changed, 122 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml

Comments

Jon Hunter Jan. 27, 2023, 2:59 p.m. UTC | #1 
On 26/01/2023 15:05, Jon Hunter wrote:
> 
> On 26/01/2023 11:36, Krzysztof Kozlowski wrote:
>> On 25/01/2023 21:42, Jon Hunter wrote:
>>> From: Wayne Chang <waynec@nvidia.com>
>>>
>>> Add the device-tree binding documentation for Cypress cypd4226 dual
>>> Type-C controller.
>>>
>>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>
>>> +
>>> +  firmware-name:
>>> +    enum:
>>> +      - nvidia,gpu
>>> +      - nvidia,jetson-agx-xavier
>>> +    description: |
>>> +      The name of the CCGx firmware built for product series.
>>> +      should be set one of following:
>>> +      - "nvidia,gpu" for the NVIDIA RTX product series
>>> +      - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series
>>> +
>>> +patternProperties:
>>> +  '^connector@[0-1]+$':
>>> +    $ref: /schemas/connector/usb-connector.yaml#
>>
>> No improvements here
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
> 
> 
> Hmmm ... I think I misinterpreted what you were asking/suggesting. OK, 
> let me fix this up.


Apologies for royally messing this up. What makes it worse is that this 
should have been fixed after V1 [0]. I have re-spun and will send out 
again shortly.

Jon

[0] 
https://lore.kernel.org/linux-tegra/f491fde0-5448-ddf2-d227-c42e30fd37d8@nvidia.com/