| Message ID | 20230118020152.1689213-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | d7fd8634f48d76aa799ed57beb7d87dab91bde80 |
| Headers | show |
| Series | drm/msm: use strscpy instead of strncpy | expand |
On 1/17/2023 6:01 PM, Dmitry Baryshkov wrote: > Using strncpy can result in non-NULL-terminated destination string. Use > strscpy instead. This fixes following warning: > > drivers/gpu/drm/msm/msm_fence.c: In function ‘msm_fence_context_alloc’: > drivers/gpu/drm/msm/msm_fence.c:25:9: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 25 | strncpy(fctx->name, name, sizeof(fctx->name)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: f97decac5f4c ("drm/msm: Support multiple ringbuffers") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/msm_fence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_fence.c b/drivers/gpu/drm/msm/msm_fence.c > index a47e5837c528..56641408ea74 100644 > --- a/drivers/gpu/drm/msm/msm_fence.c > +++ b/drivers/gpu/drm/msm/msm_fence.c > @@ -22,7 +22,7 @@ msm_fence_context_alloc(struct drm_device *dev, volatile uint32_t *fenceptr, > return ERR_PTR(-ENOMEM); > > fctx->dev = dev; > - strncpy(fctx->name, name, sizeof(fctx->name)); > + strscpy(fctx->name, name, sizeof(fctx->name)); > fctx->context = dma_fence_context_alloc(1); > fctx->index = index++; > fctx->fenceptr = fenceptr;
On Wed, 18 Jan 2023 04:01:52 +0200, Dmitry Baryshkov wrote: > Using strncpy can result in non-NULL-terminated destination string. Use > strscpy instead. This fixes following warning: > > drivers/gpu/drm/msm/msm_fence.c: In function ‘msm_fence_context_alloc’: > drivers/gpu/drm/msm/msm_fence.c:25:9: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 25 | strncpy(fctx->name, name, sizeof(fctx->name)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Applied, thanks! [1/1] drm/msm: use strscpy instead of strncpy https://gitlab.freedesktop.org/lumag/msm/-/commit/d7fd8634f48d Best regards,
diff --git a/drivers/gpu/drm/msm/msm_fence.c b/drivers/gpu/drm/msm/msm_fence.c index a47e5837c528..56641408ea74 100644 --- a/drivers/gpu/drm/msm/msm_fence.c +++ b/drivers/gpu/drm/msm/msm_fence.c @@ -22,7 +22,7 @@ msm_fence_context_alloc(struct drm_device *dev, volatile uint32_t *fenceptr, return ERR_PTR(-ENOMEM); fctx->dev = dev; - strncpy(fctx->name, name, sizeof(fctx->name)); + strscpy(fctx->name, name, sizeof(fctx->name)); fctx->context = dma_fence_context_alloc(1); fctx->index = index++; fctx->fenceptr = fenceptr;
Using strncpy can result in non-NULL-terminated destination string. Use strscpy instead. This fixes following warning: drivers/gpu/drm/msm/msm_fence.c: In function ‘msm_fence_context_alloc’: drivers/gpu/drm/msm/msm_fence.c:25:9: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] 25 | strncpy(fctx->name, name, sizeof(fctx->name)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: f97decac5f4c ("drm/msm: Support multiple ringbuffers") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/msm_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)