| Message ID | 20230124232059.4017615-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/arm: Use TYPE_ARM_SMMUV3 | expand |
On 25/1/23 00:20, Richard Henderson wrote: > Use the macro instead of two explicit string literals. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > hw/arm/sbsa-ref.c | 3 ++- > hw/arm/virt.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Hi, On 1/25/23 00:20, Richard Henderson wrote: > Use the macro instead of two explicit string literals. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > --- > hw/arm/sbsa-ref.c | 3 ++- > hw/arm/virt.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c > index 4bb444684f..8378441dbb 100644 > --- a/hw/arm/sbsa-ref.c > +++ b/hw/arm/sbsa-ref.c > @@ -29,6 +29,7 @@ > #include "exec/hwaddr.h" > #include "kvm_arm.h" > #include "hw/arm/boot.h" > +#include "hw/arm/smmuv3.h" > #include "hw/block/flash.h" > #include "hw/boards.h" > #include "hw/ide/internal.h" > @@ -574,7 +575,7 @@ static void create_smmu(const SBSAMachineState *sms, PCIBus *bus) > DeviceState *dev; > int i; > > - dev = qdev_new("arm-smmuv3"); > + dev = qdev_new(TYPE_ARM_SMMUV3); > > object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus), > &error_abort); > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 5f1fddd210..d103de8c2e 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1344,7 +1344,7 @@ static void create_smmu(const VirtMachineState *vms, > return; > } > > - dev = qdev_new("arm-smmuv3"); > + dev = qdev_new(TYPE_ARM_SMMUV3); > > object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus), > &error_abort);
On Tue, 24 Jan 2023 at 23:21, Richard Henderson <richard.henderson@linaro.org> wrote: > > Use the macro instead of two explicit string literals. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > hw/arm/sbsa-ref.c | 3 ++- > hw/arm/virt.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 4bb444684f..8378441dbb 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -29,6 +29,7 @@ #include "exec/hwaddr.h" #include "kvm_arm.h" #include "hw/arm/boot.h" +#include "hw/arm/smmuv3.h" #include "hw/block/flash.h" #include "hw/boards.h" #include "hw/ide/internal.h" @@ -574,7 +575,7 @@ static void create_smmu(const SBSAMachineState *sms, PCIBus *bus) DeviceState *dev; int i; - dev = qdev_new("arm-smmuv3"); + dev = qdev_new(TYPE_ARM_SMMUV3); object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus), &error_abort); diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5f1fddd210..d103de8c2e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1344,7 +1344,7 @@ static void create_smmu(const VirtMachineState *vms, return; } - dev = qdev_new("arm-smmuv3"); + dev = qdev_new(TYPE_ARM_SMMUV3); object_property_set_link(OBJECT(dev), "primary-bus", OBJECT(bus), &error_abort);
Use the macro instead of two explicit string literals. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- hw/arm/sbsa-ref.c | 3 ++- hw/arm/virt.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)