| Message ID | 20230113074715.32016-1-lukas.bulwahn@gmail.com |
|---|---|
| State | Accepted |
| Commit | b0f4f74631979afaff6b5b7b8e54eb1cf2bd5cfa |
| Headers | show |
| Series | crypto: atmel-i2c - avoid defines prefixed with CONFIG | expand |
On Fri, Jan 13, 2023 at 08:47:15AM +0100, Lukas Bulwahn wrote: > Defines prefixed with "CONFIG" should be limited to proper Kconfig options, > that are introduced in a Kconfig file. > > Here, a definition for the driver's configuration zone is named > CONFIG_ZONE. Rename this local definition to CONFIGURATION_ZONE to avoid > defines prefixed with "CONFIG". > > No functional change. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > Herbert, David, please pick this clean-up work into your crypto tree. Thanks. > > drivers/crypto/atmel-i2c.c | 2 +- > drivers/crypto/atmel-i2c.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c index 55bff1e13142..66e27f71e37e 100644 --- a/drivers/crypto/atmel-i2c.c +++ b/drivers/crypto/atmel-i2c.c @@ -59,7 +59,7 @@ void atmel_i2c_init_read_cmd(struct atmel_i2c_cmd *cmd) * Read the word from Configuration zone that contains the lock bytes * (UserExtra, Selector, LockValue, LockConfig). */ - cmd->param1 = CONFIG_ZONE; + cmd->param1 = CONFIGURATION_ZONE; cmd->param2 = cpu_to_le16(DEVICE_LOCK_ADDR); cmd->count = READ_COUNT; diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h index 35f7857a7f7c..c1fdc04eac07 100644 --- a/drivers/crypto/atmel-i2c.h +++ b/drivers/crypto/atmel-i2c.h @@ -63,7 +63,7 @@ struct atmel_i2c_cmd { #define STATUS_WAKE_SUCCESSFUL 0x11 /* Definitions for eeprom organization */ -#define CONFIG_ZONE 0 +#define CONFIGURATION_ZONE 0 /* Definitions for Indexes common to all commands */ #define RSP_DATA_IDX 1 /* buffer index of data in response */
Defines prefixed with "CONFIG" should be limited to proper Kconfig options, that are introduced in a Kconfig file. Here, a definition for the driver's configuration zone is named CONFIG_ZONE. Rename this local definition to CONFIGURATION_ZONE to avoid defines prefixed with "CONFIG". No functional change. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Herbert, David, please pick this clean-up work into your crypto tree. Thanks. drivers/crypto/atmel-i2c.c | 2 +- drivers/crypto/atmel-i2c.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)