mbox series

[v4,0/2] mac80211_hwsim: Add PMSR support

Message ID 20230120174934.3528469-1-jaewan@google.com
Headers show
Series mac80211_hwsim: Add PMSR support | expand

Message

Jaewan Kim Jan. 20, 2023, 5:49 p.m. UTC
Dear Kernel maintainers,

I'm proposing series of CLs for adding PMSR support in the mac80211_hwsim.

PMSR (peer measurement) is generalized measurement between STAs,
and currently FTM (fine time measurement or flight time measurement)
is the one and only measurement.

FTM measures the RTT (round trip time) and FTM can be used to measure
distances between two STAs. RTT is often referred as 'measuring distance'
as well.


Kernel had already defined protocols for PMSR in the
include/uapi/linux/nl80211.h and relevant parsing/sending code are in the
net/wireless/pmsr.c, but they are only used in intel's iwlwifi driver.

This series of CLs are the first attempt to utilize PMSR in the mac80211_hwsim.

CLs are tested with iw tool on Virtual Android device (a.k.a. Cuttlefish).
Hope this explains my CLs.

Many Thanks,


Jaewan Kim (2):
  mac80211_hwsim: add PMSR capability support
  mac80211_hwsim: handle FTM requests with virtio

 drivers/net/wireless/mac80211_hwsim.c | 827 +++++++++++++++++++++++++-
 drivers/net/wireless/mac80211_hwsim.h |  56 +-
 include/net/cfg80211.h                |  20 +
 net/wireless/nl80211.c                |  28 +-
 4 files changed, 913 insertions(+), 18 deletions(-)

Comments

Greg KH Jan. 21, 2023, 7:22 a.m. UTC | #1
On Fri, Jan 20, 2023 at 05:49:32PM +0000, Jaewan Kim wrote:
> Dear Kernel maintainers,
> 
> I'm proposing series of CLs for adding PMSR support in the mac80211_hwsim.
> 
> PMSR (peer measurement) is generalized measurement between STAs,
> and currently FTM (fine time measurement or flight time measurement)
> is the one and only measurement.
> 
> FTM measures the RTT (round trip time) and FTM can be used to measure
> distances between two STAs. RTT is often referred as 'measuring distance'
> as well.
> 
> 
> Kernel had already defined protocols for PMSR in the
> include/uapi/linux/nl80211.h and relevant parsing/sending code are in the
> net/wireless/pmsr.c, but they are only used in intel's iwlwifi driver.
> 
> This series of CLs are the first attempt to utilize PMSR in the mac80211_hwsim.
> 
> CLs are tested with iw tool on Virtual Android device (a.k.a. Cuttlefish).
> Hope this explains my CLs.
> 
> Many Thanks,
> 
> 
> Jaewan Kim (2):
>   mac80211_hwsim: add PMSR capability support
>   mac80211_hwsim: handle FTM requests with virtio
> 
>  drivers/net/wireless/mac80211_hwsim.c | 827 +++++++++++++++++++++++++-
>  drivers/net/wireless/mac80211_hwsim.h |  56 +-
>  include/net/cfg80211.h                |  20 +
>  net/wireless/nl80211.c                |  28 +-
>  4 files changed, 913 insertions(+), 18 deletions(-)
> 
> -- 
> 2.39.0.246.g2a6d74b583-goog
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Greg KH Jan. 21, 2023, 7:23 a.m. UTC | #2
On Fri, Jan 20, 2023 at 05:49:33PM +0000, Jaewan Kim wrote:
> This CL allows mac80211_hwsim to be configured with PMSR capability.
> The capability is mandatory because nl80211_pmsr_start() ignores
> incoming PMSR request if PMSR capability isn't set in the wiphy.
> 
> This CL adds HWSIM_ATTR_PMSR_SUPPORT.
> It can be used to set PMSR capability when creating a new radio.
> To send extra details, HWSIM_ATTR_PMSR_SUPPORT can have nested
> PMSR capability attributes defined in the nl80211.h.
> Data format is the same as cfg80211_pmsr_capabilities.
> 
> If HWSIM_ATTR_PMSR_SUPPORT is specified, mac80211_hwsim builds
> cfg80211_pmsr_capabilities and sets wiphy.pmsr_capa.
> 
> Signed-off-by: Jaewan Kim <jaewan@google.com>
> ---

Always run scripts/checkpatch.pl on your submissions before sending them
in so you do not get grumpy maintainers asking you why you did not run
scripts/checkpatch.pl in your submission :(