| Message ID | 20230111083909.42624-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | bulk: Replace TARGET_FMT_plx by HWADDR_PRIx | expand |
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: > Since v1: > - Fix checkpatch style violations > - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) > > Supersedes: <20230110212947.34557-1-philmd@linaro.org> > "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" > > Philippe Mathieu-Daudé (4): > hw: Remove hardcoded tabs (code style) > bulk: Coding style fixes > bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx > bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format Big sorry, I picked up v1 for my last pull request before I saw that there is a v2. But IMHO it's ok to have a separate macro with a %016 included, so I'd rather tend to keep HWADDR_FMT_plx. Anyway, if you consider the other changes in your series important enough, please rebase them. Sorry again for the additional work that this might cause. Thomas
On Fri, 20 Jan 2023, Thomas Huth wrote: > On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote: >> Since v1: >> - Fix checkpatch style violations >> - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) >> >> Supersedes: <20230110212947.34557-1-philmd@linaro.org> >> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" >> >> Philippe Mathieu-Daudé (4): >> hw: Remove hardcoded tabs (code style) >> bulk: Coding style fixes >> bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx >> bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format > > Big sorry, I picked up v1 for my last pull request before I saw that there is > a v2. But IMHO it's ok to have a separate macro with a %016 included, so I'd > rather tend to keep HWADDR_FMT_plx. Anyway, if you consider the other changes > in your series important enough, please rebase them. Sorry again for the > additional work that this might cause. I don't mind too much so maybe isn't worth the churn to have another patch for this. I'll let Philippe decide what he wants to do with it. Regards, BALATON Zoltan
Since v1: - Fix checkpatch style violations - Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan) Supersedes: <20230110212947.34557-1-philmd@linaro.org> "bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx" Philippe Mathieu-Daudé (4): hw: Remove hardcoded tabs (code style) bulk: Coding style fixes bulk: Replace TARGET_FMT_plx -> HWADDR_PRIx bulk: Prefix '0x' to hex values displayed with HWADDR_PRIx format accel/tcg/cputlb.c | 2 +- hw/arm/strongarm.c | 24 ++-- hw/block/pflash_cfi01.c | 5 +- hw/char/digic-uart.c | 8 +- hw/char/etraxfs_ser.c | 4 +- hw/core/loader.c | 8 +- hw/core/sysbus.c | 5 +- hw/display/cirrus_vga.c | 4 +- hw/display/g364fb.c | 4 +- hw/display/vga.c | 8 +- hw/dma/etraxfs_dma.c | 196 ++++++++++++++-------------- hw/dma/pl330.c | 26 ++-- hw/dma/xilinx_axidma.c | 4 +- hw/dma/xlnx_csu_dma.c | 4 +- hw/i2c/mpc_i2c.c | 4 +- hw/i386/multiboot.c | 9 +- hw/i386/xen/xen-hvm.c | 9 +- hw/i386/xen/xen-mapcache.c | 21 +-- hw/i386/xen/xen_platform.c | 4 +- hw/intc/arm_gicv3_dist.c | 8 +- hw/intc/arm_gicv3_its.c | 14 +- hw/intc/arm_gicv3_redist.c | 8 +- hw/intc/exynos4210_combiner.c | 20 +-- hw/misc/auxbus.c | 3 +- hw/misc/ivshmem.c | 6 +- hw/misc/macio/mac_dbdma.c | 4 +- hw/misc/mst_fpga.c | 162 ++++++++++++----------- hw/net/allwinner-sun8i-emac.c | 4 +- hw/net/allwinner_emac.c | 8 +- hw/net/fsl_etsec/etsec.c | 4 +- hw/net/fsl_etsec/rings.c | 4 +- hw/net/pcnet.c | 4 +- hw/net/rocker/rocker.c | 26 ++-- hw/net/rocker/rocker_desc.c | 2 +- hw/net/xilinx_axienet.c | 4 +- hw/net/xilinx_ethlite.c | 6 +- hw/pci-bridge/pci_expander_bridge.c | 2 +- hw/pci-host/bonito.c | 14 +- hw/pci-host/ppce500.c | 4 +- hw/pci/pci_host.c | 4 +- hw/ppc/ppc4xx_sdram.c | 2 +- hw/rtc/exynos4210_rtc.c | 4 +- hw/sh4/sh7750.c | 4 +- hw/ssi/xilinx_spi.c | 4 +- hw/ssi/xilinx_spips.c | 8 +- hw/timer/digic-timer.c | 8 +- hw/timer/etraxfs_timer.c | 3 +- hw/timer/exynos4210_mct.c | 2 +- hw/timer/exynos4210_pwm.c | 4 +- hw/virtio/virtio-mmio.c | 4 +- hw/xen/xen_pt.c | 4 +- include/exec/hwaddr.h | 1 - monitor/misc.c | 2 +- softmmu/memory.c | 19 +-- softmmu/memory_mapping.c | 4 +- softmmu/physmem.c | 10 +- target/i386/monitor.c | 6 +- target/loongarch/tlb_helper.c | 2 +- target/microblaze/op_helper.c | 2 +- target/mips/tcg/sysemu/tlb_helper.c | 2 +- target/ppc/mmu-hash32.c | 20 +-- target/ppc/mmu-hash64.c | 12 +- target/ppc/mmu_common.c | 30 +++-- target/ppc/mmu_helper.c | 4 +- target/riscv/cpu_helper.c | 10 +- target/riscv/monitor.c | 2 +- target/sparc/ldst_helper.c | 6 +- target/sparc/mmu_helper.c | 13 +- target/tricore/helper.c | 2 +- 69 files changed, 430 insertions(+), 424 deletions(-)