diff mbox series

[v2] target/tricore: Remove unused fields from CPUTriCoreState

Message ID 20230118093322.49307-1-philmd@linaro.org
State Superseded
Headers show
Series [v2] target/tricore: Remove unused fields from CPUTriCoreState | expand

Commit Message

Philippe Mathieu-Daudé Jan. 18, 2023, 9:33 a.m. UTC 
Remove dead code:
- unused fields in CPUTriCoreState
- (unexisting) tricore_def_t structure
- forward declaration of tricore_boot_info structure
  (declared in "hw/tricore/tricore.h", used once in
   hw/tricore/tricore_testboard.c).

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
v2: Do not remove 'hflags' in case it used:
    https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/
---
 target/tricore/cpu.h | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Richard Henderson Jan. 18, 2023, 7:01 p.m. UTC | #1 
On 1/17/23 23:33, Philippe Mathieu-Daudé wrote:
> Remove dead code:
> - unused fields in CPUTriCoreState
> - (unexisting) tricore_def_t structure
> - forward declaration of tricore_boot_info structure
>    (declared in "hw/tricore/tricore.h", used once in
>     hw/tricore/tricore_testboard.c).
> 
> Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> Reviewed-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> v2: Do not remove 'hflags' in case it used:
>      https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/

No, remove it, I don't expect it would ever be used.


r~
Bastian Koppelmann Jan. 19, 2023, 7:20 a.m. UTC | #2 
On Wed, Jan 18, 2023 at 09:01:48AM -1000, Richard Henderson wrote:
> On 1/17/23 23:33, Philippe Mathieu-Daudé wrote:
> > Remove dead code:
> > - unused fields in CPUTriCoreState
> > - (unexisting) tricore_def_t structure
> > - forward declaration of tricore_boot_info structure
> >    (declared in "hw/tricore/tricore.h", used once in
> >     hw/tricore/tricore_testboard.c).
> > 
> > Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> > Reviewed-by: Bastian Koppelmann<kbastian@mail.uni-paderborn.de>
> > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> > ---
> > v2: Do not remove 'hflags' in case it used:
> >      https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/
> 
> No, remove it, I don't expect it would ever be used.

Agreed, patch v1 is fine.

Cheers,
Bastian
diff mbox series

Patch

diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
index 3b9c533a7c..4f6d936824 100644
--- a/target/tricore/cpu.h
+++ b/target/tricore/cpu.h
@@ -25,10 +25,6 @@ 
 #include "qemu/cpu-float.h"
 #include "tricore-defs.h"
 
-struct tricore_boot_info;
-
-typedef struct tricore_def_t tricore_def_t;
-
 typedef struct CPUArchState {
     /* GPR Register */
     uint32_t gpr_a[16];
@@ -180,15 +176,10 @@  typedef struct CPUArchState {
     /* Floating Point Registers */
     float_status fp_status;
     /* QEMU */
-    int error_code;
     uint32_t hflags;    /* CPU State */
 
     /* Internal CPU feature flags.  */
     uint64_t features;
-
-    const tricore_def_t *cpu_model;
-    void *irq[8];
-    struct QEMUTimer *timer; /* Internal timer */
 } CPUTriCoreState;
 
 /**