| Message ID | 20230117223013.1545026-4-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | clk: qcom: msm8996: add APCS clock driver | expand |
On 17/01/2023 23:30, Dmitry Baryshkov wrote: > Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 > and qcs404. Correct the list of platforms in the corresponding clause. > > Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 33 ++++++++++++++----- > 1 file changed, 25 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index ecc286ab49ef..7d8de7a16984 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -72,15 +72,8 @@ allOf: > compatible: > enum: > - qcom,msm8916-apcs-kpss-global > - - qcom,msm8994-apcs-kpss-global > - - qcom,msm8996-apcs-hmss-global > - - qcom,msm8998-apcs-hmss-global > + - qcom,msm8939-apcs-kpss-global > - qcom,qcs404-apcs-apps-global > - - qcom,sc7180-apss-shared > - - qcom,sdm660-apcs-hmss-global > - - qcom,sdm845-apss-shared > - - qcom,sm6125-apcs-hmss-global > - - qcom,sm8150-apss-shared > then: > properties: > clocks: > @@ -124,6 +117,30 @@ allOf: > items: > - const: pll > - const: xo > + > + - if: > + properties: > + compatible: > + enum: > + - qcom,msm8953-apcs-kpss-global > + - qcom,msm8976-apcs-kpss-global > + - qcom,msm8994-apcs-kpss-global > + - qcom,msm8996-apcs-hmss-global > + - qcom,msm8998-apcs-hmss-global > + - qcom,qcm2290-apcs-hmss-global > + - qcom,sc7180-apss-shared > + - qcom,sc8180x-apss-shared > + - qcom,sdm660-apcs-hmss-global > + - qcom,sdm845-apss-shared > + - qcom,sm4250-apcs-hmss-global > + - qcom,sm6115-apcs-hmss-global > + - qcom,sm6125-apcs-hmss-global > + - qcom,sm8150-apss-shared Isn't this in multiple places now? This doesn't match what you remove either. Best regards, Krzysztof
On 18/01/2023 13:41, Krzysztof Kozlowski wrote: > On 17/01/2023 23:30, Dmitry Baryshkov wrote: >> Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 >> and qcs404. Correct the list of platforms in the corresponding clause. >> >> Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> .../mailbox/qcom,apcs-kpss-global.yaml | 33 ++++++++++++++----- >> 1 file changed, 25 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index ecc286ab49ef..7d8de7a16984 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -72,15 +72,8 @@ allOf: >> compatible: >> enum: >> - qcom,msm8916-apcs-kpss-global >> - - qcom,msm8994-apcs-kpss-global >> - - qcom,msm8996-apcs-hmss-global >> - - qcom,msm8998-apcs-hmss-global >> + - qcom,msm8939-apcs-kpss-global >> - qcom,qcs404-apcs-apps-global >> - - qcom,sc7180-apss-shared >> - - qcom,sdm660-apcs-hmss-global >> - - qcom,sdm845-apss-shared >> - - qcom,sm6125-apcs-hmss-global >> - - qcom,sm8150-apss-shared >> then: >> properties: >> clocks: >> @@ -124,6 +117,30 @@ allOf: >> items: >> - const: pll >> - const: xo >> + >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,msm8953-apcs-kpss-global >> + - qcom,msm8976-apcs-kpss-global >> + - qcom,msm8994-apcs-kpss-global >> + - qcom,msm8996-apcs-hmss-global >> + - qcom,msm8998-apcs-hmss-global >> + - qcom,qcm2290-apcs-hmss-global >> + - qcom,sc7180-apss-shared >> + - qcom,sc8180x-apss-shared >> + - qcom,sdm660-apcs-hmss-global >> + - qcom,sdm845-apss-shared >> + - qcom,sm4250-apcs-hmss-global >> + - qcom,sm6115-apcs-hmss-global >> + - qcom,sm6125-apcs-hmss-global >> + - qcom,sm8150-apss-shared > > Isn't this in multiple places now? This doesn't match what you remove > either. Yes, I addsd several platforms. I can split this into two patches: one moving the platforms and another one adding missing platforms. Would you prefer it? > > Best regards, > Krzysztof >
On 18/01/2023 14:04, Dmitry Baryshkov wrote: > On 18/01/2023 13:41, Krzysztof Kozlowski wrote: >> On 17/01/2023 23:30, Dmitry Baryshkov wrote: >>> Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 >>> and qcs404. Correct the list of platforms in the corresponding clause. >>> >>> Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> .../mailbox/qcom,apcs-kpss-global.yaml | 33 ++++++++++++++----- >>> 1 file changed, 25 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> index ecc286ab49ef..7d8de7a16984 100644 >>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> @@ -72,15 +72,8 @@ allOf: >>> compatible: >>> enum: >>> - qcom,msm8916-apcs-kpss-global >>> - - qcom,msm8994-apcs-kpss-global >>> - - qcom,msm8996-apcs-hmss-global >>> - - qcom,msm8998-apcs-hmss-global >>> + - qcom,msm8939-apcs-kpss-global >>> - qcom,qcs404-apcs-apps-global >>> - - qcom,sc7180-apss-shared >>> - - qcom,sdm660-apcs-hmss-global >>> - - qcom,sdm845-apss-shared >>> - - qcom,sm6125-apcs-hmss-global >>> - - qcom,sm8150-apss-shared >>> then: >>> properties: >>> clocks: >>> @@ -124,6 +117,30 @@ allOf: >>> items: >>> - const: pll >>> - const: xo >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,msm8953-apcs-kpss-global >>> + - qcom,msm8976-apcs-kpss-global >>> + - qcom,msm8994-apcs-kpss-global >>> + - qcom,msm8996-apcs-hmss-global >>> + - qcom,msm8998-apcs-hmss-global >>> + - qcom,qcm2290-apcs-hmss-global >>> + - qcom,sc7180-apss-shared >>> + - qcom,sc8180x-apss-shared >>> + - qcom,sdm660-apcs-hmss-global >>> + - qcom,sdm845-apss-shared >>> + - qcom,sm4250-apcs-hmss-global >>> + - qcom,sm6115-apcs-hmss-global >>> + - qcom,sm6125-apcs-hmss-global >>> + - qcom,sm8150-apss-shared >> >> Isn't this in multiple places now? This doesn't match what you remove >> either. > > Yes, I addsd several platforms. I can split this into two patches: one > moving the platforms and another one adding missing platforms. Would you > prefer it? Yes, plus you now duplicated entries, didn't you? As I pointed - some of them are in multiple places now. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index ecc286ab49ef..7d8de7a16984 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -72,15 +72,8 @@ allOf: compatible: enum: - qcom,msm8916-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,msm8998-apcs-hmss-global + - qcom,msm8939-apcs-kpss-global - qcom,qcs404-apcs-apps-global - - qcom,sc7180-apss-shared - - qcom,sdm660-apcs-hmss-global - - qcom,sdm845-apss-shared - - qcom,sm6125-apcs-hmss-global - - qcom,sm8150-apss-shared then: properties: clocks: @@ -124,6 +117,30 @@ allOf: items: - const: pll - const: xo + + - if: + properties: + compatible: + enum: + - qcom,msm8953-apcs-kpss-global + - qcom,msm8976-apcs-kpss-global + - qcom,msm8994-apcs-kpss-global + - qcom,msm8996-apcs-hmss-global + - qcom,msm8998-apcs-hmss-global + - qcom,qcm2290-apcs-hmss-global + - qcom,sc7180-apss-shared + - qcom,sc8180x-apss-shared + - qcom,sdm660-apcs-hmss-global + - qcom,sdm845-apss-shared + - qcom,sm4250-apcs-hmss-global + - qcom,sm6115-apcs-hmss-global + - qcom,sm6125-apcs-hmss-global + - qcom,sm8150-apss-shared + then: + properties: + clocks: false + clock-names: false + - if: properties: compatible:
Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 and qcs404. Correct the list of platforms in the corresponding clause. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../mailbox/qcom,apcs-kpss-global.yaml | 33 ++++++++++++++----- 1 file changed, 25 insertions(+), 8 deletions(-)