| Message ID | 20230113162214.117261-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] ASoC: dt-bindings: qcom,wsa881x: Allow sound-name-prefix | expand |
On Wed, Jan 18, 2023 at 5:25 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 17/01/2023 20:27, Rob Herring wrote: > > On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote: > >> The "slim-ifc-dev" property should not be just "true", because it allows > >> any type. > > > > Yes, but it is common, so it should be in a common schema. Though > > there's only one other binding using it (wcd9335.txt). > > This is still wcd9335 and wcd934x specific, not really common. Maybe > next Qualcomm codec would also bring it so then we can define common > schema for the codecs. But so far I think it is not really a common > property. By common, I only mean used by more than 1 binding. That's already the case, there's just not a schema for the 2nd one. In any case, can address that later. Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml index 184e8ccbdd13..39b27126cfc1 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml @@ -28,7 +28,9 @@ properties: description: GPIO spec for reset line to use maxItems: 1 - slim-ifc-dev: true + slim-ifc-dev: + description: IFC device interface + $ref: /schemas/types.yaml#/definitions/phandle clocks: maxItems: 1
The "slim-ifc-dev" property should not be just "true", because it allows any type. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)