mbox series

[v4,0/2] media: ov5640: Fix power up sequence delays

Message ID 20230103122736.18479-1-j-luthra@ti.com
Headers show
Series media: ov5640: Fix power up sequence delays | expand

Message

Jai Luthra Jan. 3, 2023, 12:27 p.m. UTC 
This series fixes the power-up sequence delays to support some 15-pin 
FFC compatible OV5640 modules.

Without appropriate delays after both gpio and register-based powerdown 
and reset the sensor SCCB was not very stable, and probe would sometimes 
fail at check_chip_id.

Changes in v4:
- Swap order of patches [1/3] and [2/3]
- Drop patch [3/3] as SW powerup does not have same timing constraints
- Move soft powerdown from the register table to powerup_sequence() 
  along with soft reset

v3: https://lore.kernel.org/all/20221227173634.5752-1-j-luthra@ti.com/

Jai Luthra (2):
  media: ov5640: Fix soft reset sequence and timings
  media: ov5640: Handle delays when no reset_gpio set

 drivers/media/i2c/ov5640.c | 55 +++++++++++++++++++++++++++-----------
 1 file changed, 39 insertions(+), 16 deletions(-)

Comments

Sakari Ailus Jan. 16, 2023, 7:14 p.m. UTC | #1 
On Tue, Jan 03, 2023 at 06:07:38PM +0100, Jacopo Mondi wrote:
> > +	/* software standby: allows registers programming;
> > +	 * exit at restore_mode() for CSI, s_stream(1) for DVP
> > +	 */
> 
> Multiline comments are usually written as
> 
> 	/*
>          * Software standby: allows registers programming;
> 	 * exit at restore_mode() for CSI, s_stream(1) for DVP
> 	 */
> 
> It's a trivial change, I'm not collecting patches so I can't offer to
> change it when doing so, but maybe Sakari could help with that so that
> you don't have to send a new version ? (if that's the only comment you
> receive ofc)

Works for me.

> 
> The patch looks good to me
> 
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonaboard.com>

Thanks!