diff mbox series

[1/5] i2c: cadence: Remove unused CDNS_I2C_DATA_INTR_DEPTH define

Message ID 20230107211814.1179438-2-lars@metafoo.de
State New
Headers show
Series i2c: cadence: Small cleanups | expand

Commit Message

Lars-Peter Clausen Jan. 7, 2023, 9:18 p.m. UTC 
The CDNS_I2C_DATA_INTR_DEPTH is not used in the Cadence I2C driver. Remove
it.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/i2c/busses/i2c-cadence.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Michal Simek Jan. 16, 2023, 2:37 p.m. UTC | #1 
On 1/7/23 22:18, Lars-Peter Clausen wrote:
> 
> The CDNS_I2C_DATA_INTR_DEPTH is not used in the Cadence I2C driver. Remove
> it.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>   drivers/i2c/busses/i2c-cadence.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index f58943cb1341..71ea658f4bd3 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -115,8 +115,6 @@
>   #define CNDS_I2C_PM_TIMEOUT            1000    /* ms */
> 
>   #define CDNS_I2C_FIFO_DEPTH            16
> -/* FIFO depth at which the DATA interrupt occurs */
> -#define CDNS_I2C_DATA_INTR_DEPTH       (CDNS_I2C_FIFO_DEPTH - 2)
>   #define CDNS_I2C_MAX_TRANSFER_SIZE     255
>   /* Transfer size in multiples of data interrupt depth */
>   #define CDNS_I2C_TRANSFER_SIZE (CDNS_I2C_MAX_TRANSFER_SIZE - 3)
> --
> 2.30.2
> 

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal
Wolfram Sang Jan. 20, 2023, 8:56 a.m. UTC | #2 
On Sat, Jan 07, 2023 at 01:18:10PM -0800, Lars-Peter Clausen wrote:
> The CDNS_I2C_DATA_INTR_DEPTH is not used in the Cadence I2C driver. Remove
> it.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index f58943cb1341..71ea658f4bd3 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -115,8 +115,6 @@ 
 #define CNDS_I2C_PM_TIMEOUT		1000	/* ms */
 
 #define CDNS_I2C_FIFO_DEPTH		16
-/* FIFO depth at which the DATA interrupt occurs */
-#define CDNS_I2C_DATA_INTR_DEPTH	(CDNS_I2C_FIFO_DEPTH - 2)
 #define CDNS_I2C_MAX_TRANSFER_SIZE	255
 /* Transfer size in multiples of data interrupt depth */
 #define CDNS_I2C_TRANSFER_SIZE	(CDNS_I2C_MAX_TRANSFER_SIZE - 3)