| Message ID | 20230113083720.39224-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: display/msm: rework MDP5 and MDSS schema | expand |
On Fri, Jan 13, 2023 at 09:26:52AM -0600, Rob Herring wrote: > > On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote: > > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema: > > - MSM8996 has additional "iommu" clock, define it separately > > - Add new properties used on some of platforms: > > - interconnects, interconnect-names > > - iommus > > - power-domains > > - operating-points-v2, opp-table > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > .../devicetree/bindings/display/msm/mdp5.txt | 132 ----------------- > > .../bindings/display/msm/qcom,mdp5.yaml | 138 ++++++++++++++++++ > > 2 files changed, 138 insertions(+), 132 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/msm/mdp5.txt > > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230113083720.39224-2-dmitry.baryshkov@linaro.org > > > mdp@1a01000: compatible:0: 'qcom,mdp5' was expected > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb > > mdp@1a01000: compatible: ['qcom,msm8953-mdp5', 'qcom,mdp5'] is too long > arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb If your thought is to drop 'qcom,msm8953-mdp5' here that doesn't really seem great. Rob
On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: > - interconnects, interconnect-names > - iommus > - power-domains > - operating-points-v2, opp-table > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/display/msm/mdp5.txt | 132 ----------------- > .../bindings/display/msm/qcom,mdp5.yaml | 138 ++++++++++++++++++ > 2 files changed, 138 insertions(+), 132 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/msm/mdp5.txt > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, Jan 13, 2023 at 10:37:12AM +0200, Dmitry Baryshkov wrote: > Add (optional) core clock to the mdss bindings to let the MDSS driver > access harware registers before MDP driver probes. typo > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/display/msm/qcom,mdss.yaml | 34 ++++++++++++++----- > 1 file changed, 26 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > index dcde34ffc8d0..6948ae3ac7bc 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > @@ -45,17 +45,11 @@ properties: > > clocks: > minItems: 1 > - items: > - - description: Display abh clock > - - description: Display axi clock > - - description: Display vsync clock > + maxItems: 4 > > clock-names: > minItems: 1 > - items: > - - const: iface > - - const: bus > - - const: vsync > + maxItems: 4 > > "#address-cells": > const: 1 > @@ -69,6 +63,30 @@ properties: > items: > - description: MDSS_CORE reset > > +oneOf: This is not based on compatible? If not rather than at the top level, you can do 'oneOf' under 'clocks' and 'clock-names'. > + - properties: > + clocks: > + minItems: 3 > + maxItems: 4 > + > + clock-names: > + minItems: 3 > + items: > + - const: iface > + - const: bus > + - const: vsync > + - const: core > + - properties: > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + items: > + - const: iface > + - const: core > + > required: > - compatible > - reg > -- > 2.39.0 >