diff mbox series

ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA

Message ID 20221230055839.80885-1-tamim@fusetak.com
State Accepted
Commit 77c7248882385397cd7dffe9e1437f59f32ce2de
Headers show
Series ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA | expand

Commit Message

Tamim Khan Dec. 30, 2022, 5:58 a.m. UTC 
Like the Asus Expertbook B2502CBA and various Asus Vivobook laptops,
the Asus Expertbook B2402CBA has an ACPI DSDT table that describes IRQ 1
as ActiveLow while the kernel overrides it to Edge_High. This prevents the 
keyboard from working. To fix this issue, add this laptop to the 
skip_override_table so that the kernel does not override IRQ 1.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216864
Tested-by: zelenat <zelenat@gmail.com>
Signed-off-by: Tamim Khan <tamim@fusetak.com>
---
This patch is very similar to 7203481fd12b1257938519efb2460ea02b9236ee
(ACPI: resource: Add Asus ExpertBook B2502 to Asus quirks) and just adds
another ExpertBook that has the same IRQ override problem to the quirks list.

 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Rafael J. Wysocki Jan. 11, 2023, 8:14 p.m. UTC | #1 
On Fri, Dec 30, 2022 at 6:59 AM Tamim Khan <tamim@fusetak.com> wrote:
>
> Like the Asus Expertbook B2502CBA and various Asus Vivobook laptops,
> the Asus Expertbook B2402CBA has an ACPI DSDT table that describes IRQ 1
> as ActiveLow while the kernel overrides it to Edge_High. This prevents the
> keyboard from working. To fix this issue, add this laptop to the
> skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216864
> Tested-by: zelenat <zelenat@gmail.com>
> Signed-off-by: Tamim Khan <tamim@fusetak.com>
> ---
> This patch is very similar to 7203481fd12b1257938519efb2460ea02b9236ee
> (ACPI: resource: Add Asus ExpertBook B2502 to Asus quirks) and just adds
> another ExpertBook that has the same IRQ override problem to the quirks list.
>
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 16dcd31d124f..153e3f8b446f 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
>                 },
>         },
> +       {
> +               .ident = "Asus ExpertBook B2402CBA",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "B2402CBA"),
> +               },
> +       },
>         {
>                 .ident = "Asus ExpertBook B2502",
>                 .matches = {
> --

Applied as 6.2-rc material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 16dcd31d124f..153e3f8b446f 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -432,6 +432,13 @@  static const struct dmi_system_id asus_laptop[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
 		},
 	},
+	{
+		.ident = "Asus ExpertBook B2402CBA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "B2402CBA"),
+		},
+	},
 	{
 		.ident = "Asus ExpertBook B2502",
 		.matches = {