| Message ID | 20230103110255.2699-1-sensor1010@163.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] drivers/fsl_linflexuart.c : remove redundant uart type | expand |
On 03. 01. 23, 12:02, lizhe wrote: > in linflex_config_port() the member variable will be > assigned again . see linflex_config_port() Fine, but can you make the subject and the commit message a little bit saner? I.e. no tabs, no spaces before semicolons and colons. The subject should be something like "serial: linflexuart: remove redundant uart type _assignment_" and so on. > Signed-off-by: lizhe <sensor1010@163.com> Is this your legal name? > --- > drivers/tty/serial/fsl_linflexuart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 6fc21b6684e6..34400cc6ac7f 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) > return PTR_ERR(sport->membase); > > sport->dev = &pdev->dev; > - sport->type = PORT_LINFLEXUART; > sport->iotype = UPIO_MEM; > sport->irq = platform_get_irq(pdev, 0); > sport->ops = &linflex_pops;
diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c index 6fc21b6684e6..34400cc6ac7f 100644 --- a/drivers/tty/serial/fsl_linflexuart.c +++ b/drivers/tty/serial/fsl_linflexuart.c @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) return PTR_ERR(sport->membase); sport->dev = &pdev->dev; - sport->type = PORT_LINFLEXUART; sport->iotype = UPIO_MEM; sport->irq = platform_get_irq(pdev, 0); sport->ops = &linflex_pops;
in linflex_config_port() the member variable will be assigned again . see linflex_config_port() Signed-off-by: lizhe <sensor1010@163.com> --- drivers/tty/serial/fsl_linflexuart.c | 1 - 1 file changed, 1 deletion(-)