| Message ID | 20220627133110.271455-1-sven@svenschwermer.de |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,v2] led: multicolor: Fix intensity setting while SW blinking | expand |
Hi, can someone have a look at this patch. I think it did not get accepted. Any complains about this? Regards, Sven > -----Ursprüngliche Nachricht----- > Von: Sven Schwermer <sven@svenschwermer.de> > Gesendet: Montag, 27. Juni 2022 15:31 > An: linux-leds@vger.kernel.org > Cc: Sven Schwermer <sven.schwermer@disruptive-technologies.com>; > jacek.anaszewski@gmail.com; Sven Schuchmann <schuchmann@schleissheimer.de>; pavel@ucw.cz > Betreff: [PATCH RESEND v2] led: multicolor: Fix intensity setting while SW blinking > > From: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > > When writing to the multi_intensity file, don't unconditionally call > led_set_brightness. By only doing this if blinking is inactive we > prevent blinking from stopping if the blinking is in its off phase while > the file is written. > > Instead, if blinking is active, the changed intensity values are applied > upon the next blink. This is consistent with changing the brightness on > monochrome LEDs with active blinking. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Tested-by: Sven Schuchmann <schuchmann@schleissheimer.de> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > --- > > Notes: > V1->V2: Change title, add tags > > drivers/leds/led-class-multicolor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c > index e317408583df..5b1479b5d32c 100644 > --- a/drivers/leds/led-class-multicolor.c > +++ b/drivers/leds/led-class-multicolor.c > @@ -59,7 +59,8 @@ static ssize_t multi_intensity_store(struct device *dev, > for (i = 0; i < mcled_cdev->num_colors; i++) > mcled_cdev->subled_info[i].intensity = intensity_value[i]; > > - led_set_brightness(led_cdev, led_cdev->brightness); > + if (!test_bit(LED_BLINK_SW, &led_cdev->work_flags)) > + led_set_brightness(led_cdev, led_cdev->brightness); > ret = size; > err_out: > mutex_unlock(&led_cdev->led_access); > > base-commit: 210e04ff768142b96452030c4c2627512b30ad95 > -- > 2.36.1
Hi Lee, I've recently recalled this patch that was ready to apply. Would you mind to take a look? On 6/27/22 15:31, Sven Schwermer wrote: > From: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > > When writing to the multi_intensity file, don't unconditionally call > led_set_brightness. By only doing this if blinking is inactive we > prevent blinking from stopping if the blinking is in its off phase while > the file is written. > > Instead, if blinking is active, the changed intensity values are applied > upon the next blink. This is consistent with changing the brightness on > monochrome LEDs with active blinking. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Tested-by: Sven Schuchmann <schuchmann@schleissheimer.de> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > --- > > Notes: > V1->V2: Change title, add tags > > drivers/leds/led-class-multicolor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c > index e317408583df..5b1479b5d32c 100644 > --- a/drivers/leds/led-class-multicolor.c > +++ b/drivers/leds/led-class-multicolor.c > @@ -59,7 +59,8 @@ static ssize_t multi_intensity_store(struct device *dev, > for (i = 0; i < mcled_cdev->num_colors; i++) > mcled_cdev->subled_info[i].intensity = intensity_value[i]; > > - led_set_brightness(led_cdev, led_cdev->brightness); > + if (!test_bit(LED_BLINK_SW, &led_cdev->work_flags)) > + led_set_brightness(led_cdev, led_cdev->brightness); > ret = size; > err_out: > mutex_unlock(&led_cdev->led_access); > > base-commit: 210e04ff768142b96452030c4c2627512b30ad95
On Mon 2022-06-27 15:31:10, Sven Schwermer wrote: > From: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > > When writing to the multi_intensity file, don't unconditionally call > led_set_brightness. By only doing this if blinking is inactive we > prevent blinking from stopping if the blinking is in its off phase while > the file is written. > > Instead, if blinking is active, the changed intensity values are applied > upon the next blink. This is consistent with changing the brightness on > monochrome LEDs with active blinking. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Tested-by: Sven Schuchmann <schuchmann@schleissheimer.de> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com> Acked-by: Pavel Machek <pavel@ucw.cz> BR, Pavel
diff --git a/drivers/leds/led-class-multicolor.c b/drivers/leds/led-class-multicolor.c index e317408583df..5b1479b5d32c 100644 --- a/drivers/leds/led-class-multicolor.c +++ b/drivers/leds/led-class-multicolor.c @@ -59,7 +59,8 @@ static ssize_t multi_intensity_store(struct device *dev, for (i = 0; i < mcled_cdev->num_colors; i++) mcled_cdev->subled_info[i].intensity = intensity_value[i]; - led_set_brightness(led_cdev, led_cdev->brightness); + if (!test_bit(LED_BLINK_SW, &led_cdev->work_flags)) + led_set_brightness(led_cdev, led_cdev->brightness); ret = size; err_out: mutex_unlock(&led_cdev->led_access);