| Message ID | 20221229142219.93427-1-mig@semihalf.com |
|---|---|
| State | Accepted |
| Commit | 91e2286160edd29d3fea8efff2dcda7df321878d |
| Headers | show |
| Series | [v3] dt-bindings: net: marvell,orion-mdio: Fix examples | expand |
On 29/12/2022 15:22, Michał Grzelak wrote: > As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f > ("dt-bindings: net: orion-mdio: Convert to JSON schema") if > 'interrupts' property is present, width of 'reg' should be 0x84. > Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add > constraints checking whether 'interrupts' property is present > and validate it against fixed values in reg. > > Signed-off-by: Michał Grzelak <mig@semihalf.com> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On Thu, Dec 29, 2022 at 3:30 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 29/12/2022 15:22, Michał Grzelak wrote: > > As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f > > ("dt-bindings: net: orion-mdio: Convert to JSON schema") if > > 'interrupts' property is present, width of 'reg' should be 0x84. > > Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add > > constraints checking whether 'interrupts' property is present > > and validate it against fixed values in reg. > > > > Signed-off-by: Michał Grzelak <mig@semihalf.com> > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions. However, there's no need to repost patches *only* to add the > tags. The upstream maintainer will do that for acks received on the > version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. Deletion of tag wasn't on purpose, it was done by accident. Would you like me to resend the patch with it being added, or leave it as is? Best regards, Michał
On 29/12/2022 15:51, Michał Grzelak wrote: > Hi Krzysztof, > > On Thu, Dec 29, 2022 at 3:30 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 29/12/2022 15:22, Michał Grzelak wrote: >>> As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f >>> ("dt-bindings: net: orion-mdio: Convert to JSON schema") if >>> 'interrupts' property is present, width of 'reg' should be 0x84. >>> Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add >>> constraints checking whether 'interrupts' property is present >>> and validate it against fixed values in reg. >>> >>> Signed-off-by: Michał Grzelak <mig@semihalf.com> >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions. However, there's no need to repost patches *only* to add the >> tags. The upstream maintainer will do that for acks received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 >> >> If a tag was not added on purpose, please state why and what changed. > > Deletion of tag wasn't on purpose, it was done by accident. Would you > like me to resend the patch with it being added, or leave it as is? No need, I added it here, so will be picked-up by maintainers. Best regards, Krzysztof
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 29 Dec 2022 15:22:19 +0100 you wrote: > As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f > ("dt-bindings: net: orion-mdio: Convert to JSON schema") if > 'interrupts' property is present, width of 'reg' should be 0x84. > Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add > constraints checking whether 'interrupts' property is present > and validate it against fixed values in reg. > > [...] Here is the summary with links: - [v3] dt-bindings: net: marvell,orion-mdio: Fix examples https://git.kernel.org/netdev/net/c/91e2286160ed You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml index d2906b4a0f59..e35da8b01dc2 100644 --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml @@ -16,9 +16,6 @@ description: | 8k has a second unit which provides an interface with the xMDIO bus. This driver handles these interfaces. -allOf: - - $ref: "mdio.yaml#" - properties: compatible: enum: @@ -39,13 +36,38 @@ required: - compatible - reg +allOf: + - $ref: mdio.yaml# + + - if: + required: + - interrupts + + then: + properties: + reg: + items: + - items: + - $ref: /schemas/types.yaml#/definitions/cell + - const: 0x84 + + else: + properties: + reg: + items: + - items: + - $ref: /schemas/types.yaml#/definitions/cell + - enum: + - 0x4 + - 0x10 + unevaluatedProperties: false examples: - | mdio@d0072004 { compatible = "marvell,orion-mdio"; - reg = <0xd0072004 0x4>; + reg = <0xd0072004 0x84>; #address-cells = <1>; #size-cells = <0>; interrupts = <30>;
As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f ("dt-bindings: net: orion-mdio: Convert to JSON schema") if 'interrupts' property is present, width of 'reg' should be 0x84. Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add constraints checking whether 'interrupts' property is present and validate it against fixed values in reg. Signed-off-by: Michał Grzelak <mig@semihalf.com> --- Changelog: v2->v3 - drop quotes and blank line v1->v2 - remove second example - add 'if:' constraint to 'allOf:' - move 'allOf:' before 'examples:' .../bindings/net/marvell,orion-mdio.yaml | 30 ++++++++++++++++--- 1 file changed, 26 insertions(+), 4 deletions(-)