| Message ID | 20221209-dt-binding-ufs-v2-0-dc7a04699579@fairphone.com |
|---|---|
| Headers | show |
| Series | Fix some issues in QCOM UFS bindings | expand |
On 30/12/2022 08:42, Luca Weiss wrote: > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > in the bindings so the existing dts can validate successfully. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 30.12.2022 08:42, Luca Weiss wrote: > The UFS driver expects the second reg to be named "ice" otherwise the > Inline Crypto Engine won't get enabled. > > Fixes: 97e563bf5ba1 ("arm64: dts: qcom: sm6115: Add basic soc dtsi") > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=01b6041454e8bc4f5feb76e6bcdc83a48cea21f2 Konrad > arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index 572bf04adf90..85673d562723 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -704,6 +704,7 @@ opp-202000000 { > ufs_mem_hc: ufs@4804000 { > compatible = "qcom,sm6115-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; > reg = <0x04804000 0x3000>, <0x04810000 0x8000>; > + reg-names = "std", "ice"; > interrupts = <GIC_SPI 356 IRQ_TYPE_LEVEL_HIGH>; > phys = <&ufs_mem_phy_lanes>; > phy-names = "ufsphy"; >
The patches depend on the following patch adding SM6115: * https://lore.kernel.org/linux-arm-msm/20221030094258.486428-2-iskren.chernev@gmail.com/ The only remaining validation issues I see in the UFS bindings are solved with the following patches, but this series doesn't depend on them: * https://lore.kernel.org/linux-arm-msm/20221228124331.258416-1-krzysztof.kozlowski@linaro.org/ * https://lore.kernel.org/linux-arm-msm/20221205100837.29212-2-johan+linaro@kernel.org/ To: Andy Gross <agross@kernel.org> To: Bjorn Andersson <andersson@kernel.org> To: Konrad Dybcio <konrad.dybcio@linaro.org> To: Alim Akhtar <alim.akhtar@samsung.com> To: Avri Altman <avri.altman@wdc.com> To: Bart Van Assche <bvanassche@acm.org> To: Rob Herring <robh+dt@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Iskren Chernev <me@iskren.info> Cc: linux-arm-msm@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht Cc: phone-devel@vger.kernel.org Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Changes in v2: - Add new patch adding reg-names to sm6115 & rebase series on top of sm6115 addition - Fix binding example after sm8450 move, split this patch from original patch since it became too big - Move reg-names definition to top-level - Link to v1: https://lore.kernel.org/r/20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com --- Luca Weiss (3): arm64: dts: qcom: sm6115: Add missing reg-names property for UFS dt-bindings: ufs: qcom: Add reg-names property for ICE dt-bindings: ufs: qcom: Fix sm8450 bindings .../devicetree/bindings/ufs/qcom,ufs.yaml | 35 ++++++++++++++++++---- arch/arm64/boot/dts/qcom/sm6115.dtsi | 1 + 2 files changed, 31 insertions(+), 5 deletions(-) --- base-commit: 98d95cb05f231dd0f155f912ec7823475b112f6e change-id: 20221209-dt-binding-ufs-2d7f64797ff2 Best regards,