| Message ID | 20221221171222.19699-3-quic_ahari@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: ufs: Add hibernation callbacks | expand |
Hi Anjana,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20221221171222.19699-3-quic_ahari%40quicinc.com
patch subject: [PATCH 2/2] scsi: ufs: ufs-qcom: Add hibernation callbacks
config: arm64-randconfig-c031-20221225
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6a52ff7dff6d455c578cd85689d6919b6866ad02
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
git checkout 6a52ff7dff6d455c578cd85689d6919b6866ad02
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/ufs/host/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/ufs/host/ufs-qcom.c:1504:28: error: 'ufshcd_system_suspend' undeclared here (not in a function); did you mean 'ufshcd_runtime_suspend'?
1504 | .suspend = ufshcd_system_suspend,
| ^~~~~~~~~~~~~~~~~~~~~
| ufshcd_runtime_suspend
>> drivers/ufs/host/ufs-qcom.c:1505:28: error: 'ufshcd_system_resume' undeclared here (not in a function); did you mean 'ufshcd_system_restore'?
1505 | .resume = ufshcd_system_resume,
| ^~~~~~~~~~~~~~~~~~~~
| ufshcd_system_restore
vim +1504 drivers/ufs/host/ufs-qcom.c
1499
1500 static const struct dev_pm_ops ufs_qcom_pm_ops = {
1501 SET_RUNTIME_PM_OPS(ufshcd_runtime_suspend, ufshcd_runtime_resume, NULL)
1502 .prepare = ufshcd_suspend_prepare,
1503 .complete = ufshcd_resume_complete,
> 1504 .suspend = ufshcd_system_suspend,
> 1505 .resume = ufshcd_system_resume,
1506 .freeze = ufshcd_system_freeze,
1507 .restore = ufshcd_system_restore,
1508 .thaw = ufshcd_system_thaw,
1509 };
1510
Hi Anjana,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on jejb-scsi/for-next linus/master v6.2-rc1 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20221221171222.19699-3-quic_ahari%40quicinc.com
patch subject: [PATCH 2/2] scsi: ufs: ufs-qcom: Add hibernation callbacks
config: arm64-buildonly-randconfig-r001-20221226
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project f5700e7b69048de958172fb513b336564e7f8709)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/6a52ff7dff6d455c578cd85689d6919b6866ad02
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anjana-Hari/scsi-ufs-Add-hibernation-callbacks/20221222-011920
git checkout 6a52ff7dff6d455c578cd85689d6919b6866ad02
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/iommu/ drivers/ufs/host/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/ufs/host/ufs-qcom.c:1504:21: error: use of undeclared identifier 'ufshcd_system_suspend'; did you mean 'ufshcd_runtime_suspend'?
.suspend = ufshcd_system_suspend,
^~~~~~~~~~~~~~~~~~~~~
ufshcd_runtime_suspend
include/ufs/ufshcd.h:1100:12: note: 'ufshcd_runtime_suspend' declared here
extern int ufshcd_runtime_suspend(struct device *dev);
^
>> drivers/ufs/host/ufs-qcom.c:1505:21: error: use of undeclared identifier 'ufshcd_system_resume'; did you mean 'ufshcd_system_restore'?
.resume = ufshcd_system_resume,
^~~~~~~~~~~~~~~~~~~~
ufshcd_system_restore
include/ufs/ufshcd.h:1109:12: note: 'ufshcd_system_restore' declared here
extern int ufshcd_system_restore(struct device *dev);
^
2 errors generated.
vim +1504 drivers/ufs/host/ufs-qcom.c
1499
1500 static const struct dev_pm_ops ufs_qcom_pm_ops = {
1501 SET_RUNTIME_PM_OPS(ufshcd_runtime_suspend, ufshcd_runtime_resume, NULL)
1502 .prepare = ufshcd_suspend_prepare,
1503 .complete = ufshcd_resume_complete,
> 1504 .suspend = ufshcd_system_suspend,
> 1505 .resume = ufshcd_system_resume,
1506 .freeze = ufshcd_system_freeze,
1507 .restore = ufshcd_system_restore,
1508 .thaw = ufshcd_system_thaw,
1509 };
1510
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 8ad1415e10b6..ac5685b0e891 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1498,10 +1498,14 @@ MODULE_DEVICE_TABLE(acpi, ufs_qcom_acpi_match); #endif static const struct dev_pm_ops ufs_qcom_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(ufshcd_system_suspend, ufshcd_system_resume) SET_RUNTIME_PM_OPS(ufshcd_runtime_suspend, ufshcd_runtime_resume, NULL) .prepare = ufshcd_suspend_prepare, .complete = ufshcd_resume_complete, + .suspend = ufshcd_system_suspend, + .resume = ufshcd_system_resume, + .freeze = ufshcd_system_freeze, + .restore = ufshcd_system_restore, + .thaw = ufshcd_system_thaw, }; static struct platform_driver ufs_qcom_pltform = {
Adds freeze-thaw-restore callbacks for Qualcomm UFS platform. Signed-off-by: Anjana Hari <quic_ahari@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)