mbox series

[net,0/2] Orion MDIO DT binding fixes

Message ID 20221227010523.59328-1-mig@semihalf.com
Headers show
Series Orion MDIO DT binding fixes | expand

Message

Michał Grzelak Dec. 27, 2022, 1:05 a.m. UTC 
Hi all,

This patchset fixes two small bugs in orion-mdio 
binding. I would be thankful for your review.

Best regards,
Michał Grzelak

Michał Grzelak (2):
  dt-bindings: net: marvell,orion-mdio: Fix error
  dt-bindings: net: marvell,orion-mdio: Fix examples

 .../bindings/net/marvell,orion-mdio.yaml         | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 27, 2022, 8:06 a.m. UTC | #1 
On 27/12/2022 02:05, Michał Grzelak wrote:
> Fix 'unevaluated properties error' during 'make dtbs_check' appearing on
> arm device trees by defining generic 'ethernet-phy' subnode in
> marvell,orion-mdio.yaml.

Instead of long test just paste a bit of warning message. Much easier to
read.

> 
> Fixes: 0781434af811f ("dt-bindings: net: orion-mdio: Convert to JSON
> schema")

Don't wrap tags.

> Signed-off-by: Michał Grzelak <mig@semihalf.com>
> ---
>  Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> index d2906b4a0f59..2b2b3f8709fc 100644
> --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> @@ -35,6 +35,10 @@ properties:
>      minItems: 1
>      maxItems: 4
>  
> +patternProperties:
> +  '^ethernet-phy':

ethernet-phy@ is already accepted via mdio, so this looks wrong. You
need to rather fix the DTS.


Best regards,
Krzysztof