| Message ID | 20221225040821.8395-1-steev@kali.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Sun, 25 Dec 2022 at 06:08, Steev Klimaszewski <steev@kali.org> wrote: > > The Lenovo Yoga C630 can't use the generic venus firmware that is in the > linux-firmware repository, and needs a signed one. This file is > qcvss850.mbn from the Windows partition and needs to be copied manually. > > Signed-off-by: Steev Klimaszewski <steev@kali.org> > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index 7e80e2950f8d..78a14f899df9 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -801,6 +801,7 @@ &usb_2_qmpphy { > }; > > &venus { > + firmware-name = "qcom/venus-5.2/qcvss850.mbn"; Please follow the established convention (see e.g. the x13s laptop firmware). It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or qcom/sdm845/LENOVO/....). > status = "okay"; > }; > > -- > 2.35.1 >
On Sun, Dec 25, 2022 at 9:22 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Sun, 25 Dec 2022 at 06:08, Steev Klimaszewski <steev@kali.org> wrote: > > > > The Lenovo Yoga C630 can't use the generic venus firmware that is in the > > linux-firmware repository, and needs a signed one. This file is > > qcvss850.mbn from the Windows partition and needs to be copied manually. > > > > Signed-off-by: Steev Klimaszewski <steev@kali.org> > > --- > > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > index 7e80e2950f8d..78a14f899df9 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > @@ -801,6 +801,7 @@ &usb_2_qmpphy { > > }; > > > > &venus { > > + firmware-name = "qcom/venus-5.2/qcvss850.mbn"; > > Please follow the established convention (see e.g. the x13s laptop firmware). > It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or > qcom/sdm845/LENOVO/....). > > > status = "okay"; > > }; > > > > -- > > 2.35.1 > > > > > -- > With best wishes > Dmitry Thanks for pointing that out; will make the change for v2!
On Mon, 26 Dec 2022 at 02:47, Steev Klimaszewski <steev@kali.org> wrote: > > The firmware paths were pointing to qcom/manufacturer whereas other > devices have them under qcom/chipset/manufacturer, so fix this up on the > c630, so we follow the same standard setup. > > Signed-off-by: Steev Klimaszewski <steev@kali.org> Thanks! Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-)
On 26/12/2022 01:47, Steev Klimaszewski wrote: > The firmware paths were pointing to qcom/manufacturer whereas other > devices have them under qcom/chipset/manufacturer, so fix this up on the > c630, so we follow the same standard setup. > > Signed-off-by: Steev Klimaszewski <steev@kali.org> Do not attach your patches to some other threads. It messes with reading and applying. Best regards, Krzysztof
On Mon, Dec 26, 2022 at 6:04 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 26/12/2022 01:47, Steev Klimaszewski wrote: > > The firmware paths were pointing to qcom/manufacturer whereas other > > devices have them under qcom/chipset/manufacturer, so fix this up on the > > c630, so we follow the same standard setup. > > > > Signed-off-by: Steev Klimaszewski <steev@kali.org> > > Do not attach your patches to some other threads. It messes with reading > and applying. > > Best regards, > Krzysztof > Sorry, I screwed up my first patch, and this was supposed to be a v2 of that one. I'll do better on other submissions.
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index 7e80e2950f8d..78a14f899df9 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -801,6 +801,7 @@ &usb_2_qmpphy { }; &venus { + firmware-name = "qcom/venus-5.2/qcvss850.mbn"; status = "okay"; };
The Lenovo Yoga C630 can't use the generic venus firmware that is in the linux-firmware repository, and needs a signed one. This file is qcvss850.mbn from the Windows partition and needs to be copied manually. Signed-off-by: Steev Klimaszewski <steev@kali.org> --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 + 1 file changed, 1 insertion(+)