| Message ID | 20221222151319.122398-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name | expand |
On 22.12.2022 16:13, Krzysztof Kozlowski wrote: > The pin config entry should have a string, not number, for the GPIO used > as WCD9340 audio codec interrupt. > > Fixes: dd6459a0890a ("arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts") > Reported-by: Doug Anderson <dianders@chromium.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Cc: Doug Anderson <dianders@chromium.org> > > Changes since v3: > 1. New patch. > --- > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > index eb6b2b676eca..85b8a1b5f0d5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > @@ -472,7 +472,7 @@ sdc2_card_det_n: sd-card-det-n { > }; > > wcd_intr_default: wcd_intr_default { > - pins = <54>; > + pins = "gpio54"; > function = "gpio"; > > input-enable;
Hi, On Thu, Dec 22, 2022 at 7:13 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Doug Anderson <dianders@chromium.org> > > Tested on Qualcomm RB3. Please kndly test a bit more on other devices. > This should not have an functional impact. > > Changes since v3: > 1. db845c: drop qup_uart3_default override and use qup_uart3_4pin > (Doug). > > Changes since v2: > 1. Bring back UART6 4-pin bias/drive strength to DTSI. > > Changes since v1: > 1. Address comments and implement conclusion with Doug. Drop > default-pins/pinmux/mux/config nodes but instead add subnodes for > specific pins for UARTs. This should match approach used for SC7180. > > v1: https://lore.kernel.org/linux-kernel/1b9dcca8-1abd-99a3-da12-a8763bf77f12@linaro.org/ > --- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 397 ++++------ > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 93 +-- > .../arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 60 +- > arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 2 +- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 77 +- > .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 101 +-- > .../boot/dts/qcom/sdm845-shift-axolotl.dts | 150 ++-- > .../dts/qcom/sdm845-sony-xperia-tama.dtsi | 6 +- > .../qcom/sdm845-xiaomi-beryllium-common.dtsi | 12 +- > .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 21 +- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 689 ++++++++---------- > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 53 +- > .../boot/dts/qcom/sdm850-samsung-w737.dts | 121 +-- > 13 files changed, 701 insertions(+), 1081 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Thu, 22 Dec 2022 16:13:16 +0100, Krzysztof Kozlowski wrote: > The pin config entry should have a string, not number, for the GPIO used > as WCD9340 audio codec interrupt. > > Applied, thanks! [1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name commit: 740862bb5f59b93efb390a417995f88a64bdc323 [2/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: fix audio codec interrupt pin name commit: e5011447376e1b050847ccb2ef7933176ce4de41 [3/4] arm64: dts: qcom: sdm845: align TLMM pin configuration with DT schema commit: d05e342882e4fb2ccd8e4b6af00b0b82e22ad325 [4/4] arm64: dts: qcom: sdm845: do not customize SPI0 pin drive/bias commit: 0cbc0b1c5838b02c67a768392bb34732f0d384b0 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index f41c6d600ea8..774e4352f299 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -979,7 +979,7 @@ sdc2_card_det_n: sd-card-det-n { }; wcd_intr_default: wcd_intr_default { - pins = <54>; + pins = "gpio54"; function = "gpio"; input-enable;
The pin config entry should have a string, not number, for the GPIO used as WCD9340 audio codec interrupt. Fixes: 89a32a4e769c ("arm64: dts: qcom: db845c: add analog audio support") Reported-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- Cc: Doug Anderson <dianders@chromium.org> Changes since v3: 1. Add Fixes and Rb tags. Changes since v2: 1. New patch. --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)