| Message ID | 20221214044342.49766-2-sriranjani.p@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 | expand |
On Tue, 13 Dec 2022 at 22:47, Sriranjani P <sriranjani.p@samsung.com> wrote: > > Exynos850 has two different SYSREGs, hence add dedicated compatibles for > them and deprecate usage of generic Exynos850 compatible alone. > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Thanks! > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 4954790eda6c..427df05224e5 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -17,7 +17,6 @@ properties: > - samsung,exynos3-sysreg > - samsung,exynos4-sysreg > - samsung,exynos5-sysreg > - - samsung,exynos850-sysreg > - samsung,exynosautov9-sysreg > - tesla,fsd-cam-sysreg > - tesla,fsd-fsys0-sysreg > @@ -33,9 +32,17 @@ properties: > - const: samsung,exynos5433-sysreg > - const: syscon > - items: > - - const: samsung,exynos5433-sysreg > + - enum: > + - samsung,exynos5433-sysreg > + - samsung,exynos850-sysreg > + - const: syscon > + deprecated: true > + - items: > + - enum: > + - samsung,exynos850-cmgp-sysreg > + - samsung,exynos850-peri-sysreg > + - const: samsung,exynos850-sysreg > - const: syscon > - deprecated: true > > reg: > maxItems: 1 > @@ -53,6 +60,8 @@ allOf: > compatible: > contains: > enum: > + - samsung,exynos850-cmgp-sysreg > + - samsung,exynos850-peri-sysreg > - samsung,exynos850-sysreg > then: > required: > -- > 2.17.1 >
On Wed, 14 Dec 2022 10:13:39 +0530, Sriranjani P wrote: > Exynos850 has two different SYSREGs, hence add dedicated compatibles for > them and deprecate usage of generic Exynos850 compatible alone. > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > --- > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@samsung.com> wrote: > > Exynos850 has two different SYSREGs, hence add dedicated compatibles for > them and deprecate usage of generic Exynos850 compatible alone. > > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> > --- > .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 4954790eda6c..427df05224e5 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -17,7 +17,6 @@ properties: > - samsung,exynos3-sysreg > - samsung,exynos4-sysreg > - samsung,exynos5-sysreg > - - samsung,exynos850-sysreg > - samsung,exynosautov9-sysreg > - tesla,fsd-cam-sysreg > - tesla,fsd-fsys0-sysreg > @@ -33,9 +32,17 @@ properties: > - const: samsung,exynos5433-sysreg > - const: syscon > - items: > - - const: samsung,exynos5433-sysreg > + - enum: > + - samsung,exynos5433-sysreg > + - samsung,exynos850-sysreg > + - const: syscon > + deprecated: true This is throwing an error in linux-next now. How can 1 item in a list be deprecated? What's the not deprecated value for the entry? Probably this needs to move up to 'items' as the whole entry is deprecated. > + - items: > + - enum: > + - samsung,exynos850-cmgp-sysreg > + - samsung,exynos850-peri-sysreg > + - const: samsung,exynos850-sysreg > - const: syscon > - deprecated: true > > reg: > maxItems: 1 > @@ -53,6 +60,8 @@ allOf: > compatible: > contains: > enum: > + - samsung,exynos850-cmgp-sysreg > + - samsung,exynos850-peri-sysreg > - samsung,exynos850-sysreg > then: > required: > -- > 2.17.1 >
On 09/01/2023 02:15, Rob Herring wrote: > On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@samsung.com> wrote: >> >> Exynos850 has two different SYSREGs, hence add dedicated compatibles for >> them and deprecate usage of generic Exynos850 compatible alone. >> >> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> >> --- >> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >> index 4954790eda6c..427df05224e5 100644 >> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >> @@ -17,7 +17,6 @@ properties: >> - samsung,exynos3-sysreg >> - samsung,exynos4-sysreg >> - samsung,exynos5-sysreg >> - - samsung,exynos850-sysreg >> - samsung,exynosautov9-sysreg >> - tesla,fsd-cam-sysreg >> - tesla,fsd-fsys0-sysreg >> @@ -33,9 +32,17 @@ properties: >> - const: samsung,exynos5433-sysreg >> - const: syscon >> - items: >> - - const: samsung,exynos5433-sysreg >> + - enum: >> + - samsung,exynos5433-sysreg >> + - samsung,exynos850-sysreg >> + - const: syscon >> + deprecated: true > > This is throwing an error in linux-next now. > > How can 1 item in a list be deprecated? What's the not deprecated > value for the entry? Probably this needs to move up to 'items' as the > whole entry is deprecated. I missed this. I'll fix it. I'll updated my dtschema and see the error now. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml index 4954790eda6c..427df05224e5 100644 --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml @@ -17,7 +17,6 @@ properties: - samsung,exynos3-sysreg - samsung,exynos4-sysreg - samsung,exynos5-sysreg - - samsung,exynos850-sysreg - samsung,exynosautov9-sysreg - tesla,fsd-cam-sysreg - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties: - const: samsung,exynos5433-sysreg - const: syscon - items: - - const: samsung,exynos5433-sysreg + - enum: + - samsung,exynos5433-sysreg + - samsung,exynos850-sysreg + - const: syscon + deprecated: true + - items: + - enum: + - samsung,exynos850-cmgp-sysreg + - samsung,exynos850-peri-sysreg + - const: samsung,exynos850-sysreg - const: syscon - deprecated: true reg: maxItems: 1 @@ -53,6 +60,8 @@ allOf: compatible: contains: enum: + - samsung,exynos850-cmgp-sysreg + - samsung,exynos850-peri-sysreg - samsung,exynos850-sysreg then: required:
Exynos850 has two different SYSREGs, hence add dedicated compatibles for them and deprecate usage of generic Exynos850 compatible alone. Signed-off-by: Sriranjani P <sriranjani.p@samsung.com> --- .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)