mbox series

[0/8] brcm: add firmware files for brcmfmac driver

Message ID 20221207230556.383935-1-arend.vanspriel@broadcom.com
Headers show
Series brcm: add firmware files for brcmfmac driver | expand

Message

Arend van Spriel Dec. 7, 2022, 11:05 p.m. UTC 
update and add a number of firmware files that were long overdue.

Arend van Spriel (8):
  brcm: update bcm43241 firmware file
  brcm: update bcm4329 firmware file
  brcm: update bcm4330 firmware file
  brcm: update bcm4358 firmware file
  brcm: add firmware file for bcm4339
  brcm: add firmware file for bcm4354
  brcm: add firmware file for bcm4356 PCIe device
  brcm: add firmware file for bcm4356 SDIO device

 WHENCE                        |   4 ++++
 brcm/brcmfmac43241b0-sdio.bin | Bin 455745 -> 459988 bytes
 brcm/brcmfmac4329-sdio.bin    | Bin 253748 -> 246791 bytes
 brcm/brcmfmac4330-sdio.bin    | Bin 222126 -> 223581 bytes
 brcm/brcmfmac4339-sdio.bin    | Bin 0 -> 562183 bytes
 brcm/brcmfmac4354-sdio.bin    | Bin 0 -> 627021 bytes
 brcm/brcmfmac4356-pcie.bin    | Bin 0 -> 662895 bytes
 brcm/brcmfmac4356-sdio.bin    | Bin 0 -> 526383 bytes
 brcm/brcmfmac4358-pcie.bin    | Bin 633817 -> 634361 bytes
 9 files changed, 4 insertions(+)
 create mode 100644 brcm/brcmfmac4339-sdio.bin
 create mode 100755 brcm/brcmfmac4354-sdio.bin
 create mode 100644 brcm/brcmfmac4356-pcie.bin
 create mode 100644 brcm/brcmfmac4356-sdio.bin

Comments

Arend van Spriel Dec. 19, 2022, 5:20 p.m. UTC | #1 
On December 19, 2022 5:58:29 PM Dmitry Osipenko <digetx@gmail.com> wrote:

> Hi,
>
> 08.12.2022 02:05, Arend van Spriel пишет:
>> bump version from 4.220.48.0 to 4.218.248.44. Version numbering
>> scheme is obscure but this is a more recent firmware file.
>>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> ---
>> brcm/brcmfmac4329-sdio.bin | Bin 253748 -> 246791 bytes
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>
> This firmware version doesn't work on any of NVIDIA Tegra tablets
> supported by upstream kernel, tested using next-20221216. Please revert
> or fix, thanks!
>
> Faulty 4.218.248.44 kernel log:
>
> brcmfmac: brcmf_wcc_attach: executing
> brcmfmac: brcmf_c_process_clm_blob: no clm_blob available (err=-2),
> device may have limited channels available
> brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4329/3 wl0: May 25 2012
> 17:57:45 version 4.218.248.44
> ieee80211 phy0: brcmf_c_set_joinpref_default: Set join_pref error (-52)
> ieee80211 phy0: brcmf_setup_wiphybands: rxchain unsupported
> ieee80211 phy0: brcmf_construct_chaninfo: get chanspecs error (-52)
> ieee80211 phy0: brcmf_setup_wiphybands: brcmf_construct_chaninfo failed
> (-52)
> ieee80211 phy0: brcmf_cfg80211_attach: Setting wiphy bands failed (-52)
> ieee80211 phy0: brcmf_bus_started: failed: -12
> ieee80211 phy0: brcmf_attach: dongle is not responding: err=-12
> brcmfmac: brcmf_wcc_detach: executing
> brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed

Thanks, Dmitry

Could you provide the full log and insert brcmfmac with debug=0x1416 
(requires CONFIG_BRCMDBG).

Regards,
Arend

> Good 4.220.48.0 kernel log:
>
> brcmfmac: brcmf_wcc_attach: executing
> brcmfmac: brcmf_c_process_clm_blob: no clm_blob available (err=-2),
> device may have limited channels available
> brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4329/3 wl0: Sep  2 2011
> 14:48:19 version 4.220.48
> ieee80211 phy0: brcmf_setup_wiphybands: rxchain unsupported
Linus Walleij Jan. 5, 2023, 9:54 p.m. UTC | #2 
Hi Arend,

thanks for this long due update! I have tested the BCM4330 SDIO
firmware on the Samsung Janice (GT-I9070) and it works like a
charm!

I notice the absence of a new BCM4334 firmware, could you send
that too, if you have a latest-and-greatest? Some people have
problems with wireless on the Skomer (GT-S7710) and maybe a
proper firmware would solve it.

Thanks,
Linus Walleij