| Message ID | 20221216220411.6779-6-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/i386: Header cleanups around "cpu.h" | expand |
On 12/16/22 14:04, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/s390x/tcg/excp_helper.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c > index fe02d82201..e9eb7c455e 100644 > --- a/target/s390x/tcg/excp_helper.c > +++ b/target/s390x/tcg/excp_helper.c > @@ -21,15 +21,15 @@ > #include "qemu/osdep.h" > #include "qemu/log.h" > #include "cpu.h" > -#include "s390x-internal.h" > #include "exec/helper-proto.h" > -#include "qemu/timer.h" > #include "exec/exec-all.h" > -#include "exec/cpu_ldst.h" > -#include "hw/s390x/ioinst.h" > -#include "exec/address-spaces.h" > +#include "s390x-internal.h" > #include "tcg_s390x.h" > #ifndef CONFIG_USER_ONLY > +#include "qemu/timer.h" > +#include "exec/cpu_ldst.h" cpu_ldst.h is not a system header. The others look plausible. r~ > +#include "exec/address-spaces.h" > +#include "hw/s390x/ioinst.h" > #include "hw/s390x/s390_flic.h" > #include "hw/boards.h" > #endif
On 17/12/22 01:45, Richard Henderson wrote: > On 12/16/22 14:04, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> target/s390x/tcg/excp_helper.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/target/s390x/tcg/excp_helper.c >> b/target/s390x/tcg/excp_helper.c >> index fe02d82201..e9eb7c455e 100644 >> --- a/target/s390x/tcg/excp_helper.c >> +++ b/target/s390x/tcg/excp_helper.c >> @@ -21,15 +21,15 @@ >> #include "qemu/osdep.h" >> #include "qemu/log.h" >> #include "cpu.h" >> -#include "s390x-internal.h" >> #include "exec/helper-proto.h" >> -#include "qemu/timer.h" >> #include "exec/exec-all.h" >> -#include "exec/cpu_ldst.h" >> -#include "hw/s390x/ioinst.h" >> -#include "exec/address-spaces.h" >> +#include "s390x-internal.h" >> #include "tcg_s390x.h" >> #ifndef CONFIG_USER_ONLY >> +#include "qemu/timer.h" >> +#include "exec/cpu_ldst.h" > > cpu_ldst.h is not a system header. The others look plausible. Oops, correct.
diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index fe02d82201..e9eb7c455e 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/target/s390x/tcg/excp_helper.c @@ -21,15 +21,15 @@ #include "qemu/osdep.h" #include "qemu/log.h" #include "cpu.h" -#include "s390x-internal.h" #include "exec/helper-proto.h" -#include "qemu/timer.h" #include "exec/exec-all.h" -#include "exec/cpu_ldst.h" -#include "hw/s390x/ioinst.h" -#include "exec/address-spaces.h" +#include "s390x-internal.h" #include "tcg_s390x.h" #ifndef CONFIG_USER_ONLY +#include "qemu/timer.h" +#include "exec/cpu_ldst.h" +#include "exec/address-spaces.h" +#include "hw/s390x/ioinst.h" #include "hw/s390x/s390_flic.h" #include "hw/boards.h" #endif
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/s390x/tcg/excp_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)