| Message ID | 20221214070608.4128546-1-yanaijie@huawei.com |
|---|---|
| Headers | show |
| Series | scsi: libsas: Some coding style fixes and cleanups | expand |
On 14/12/2022 12:47, Jason Yan wrote: >> Note: you made the changes as I suggested, so I think that you could >> have picked up my RB tag from v2 series, thanks. > > Yeah I used to do that before. But last time Damien educated me that I > must drop all the RB tags after the patch is changed so I didn't take > it. I think that they should be dropped if significant changes are made since the original tag was granted - that's for sure. However if I supply a RB tag but also suggest a smallish change along with it and you implement that change in a new version, then it's ok to pick up the tag. At a brief glance, I could not see this policy mentioned in submitting-patches.rst . Thanks!
A few coding style fixes and cleanups. There should be no functional changes in this series besides the debug log prints. v1->v2: 1. Drop patch #2 in v1. 2. Other misc changes suggested by John. v2->v3: 1. Add John's tag for patch #1 #3 #5. 2. /s/sata/SATA/ 3. Make a global macro for prints of CONFIG_SCSI_SAS_ATA=N Jason Yan (5): scsi: libsas: move sas_get_ata_command_set() up to save the declaration scsi: libsas: change the coding style of sas_discover_sata() scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev() scsi: libsas: factor out sas_ata_add_dev() scsi: libsas: factor out sas_ex_add_dev() drivers/scsi/libsas/sas_ata.c | 88 ++++++++++++++++---- drivers/scsi/libsas/sas_discover.c | 6 -- drivers/scsi/libsas/sas_expander.c | 125 ++++++++++------------------- include/scsi/libsas.h | 1 - include/scsi/sas_ata.h | 18 +++++ 5 files changed, 132 insertions(+), 106 deletions(-)