| Message ID | 20221207204327.2810001-2-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property | expand |
On 07/12/2022 21:43, Rob Herring wrote: > 'led' nodes should have a reference to LED common.yaml schema. Add it where > missing and drop any duplicate properties. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- > .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- > .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- > 3 files changed, 7 insertions(+), 21 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 07 Dec 2022 14:43:27 -0600, Rob Herring wrote: > 'led' nodes should have a reference to LED common.yaml schema. Add it where > missing and drop any duplicate properties. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- > .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- > .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- > 3 files changed, 7 insertions(+), 21 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml index 3f13db0dc915..8b3b3bf1eaf2 100644 --- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml @@ -56,7 +56,8 @@ properties: patternProperties: "^led@[0-2]$": - type: object + $ref: common.yaml# + unevaluatedProperties: false properties: reg: diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml index c6f96cabd4d1..fdb08f44a45d 100644 --- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml +++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml @@ -30,9 +30,8 @@ properties: patternProperties: "^led@[0-2]$": - type: object - description: | - Properties for a single LED. + $ref: common.yaml# + unevaluatedProperties: false properties: reg: @@ -41,10 +40,6 @@ patternProperties: minimum: 0 maximum: 2 - label: true - - linux,default-trigger: true - required: - compatible - "#address-cells" diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml index 86a37c92b834..ca92cea56a6f 100644 --- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml @@ -26,26 +26,16 @@ properties: patternProperties: "^led-[1-2]$": - type: object - description: - Properties for a single LED. + $ref: common.yaml# + unevaluatedProperties: false + properties: - #allOf: - #- $ref: "common.yaml#" rohm,led-compatible: description: LED identification string $ref: "/schemas/types.yaml#/definitions/string" enum: - bd71828-ambled - bd71828-grnled - function: - description: - Purpose of LED as defined in dt-bindings/leds/common.h - $ref: "/schemas/types.yaml#/definitions/string" - color: - description: - LED colour as defined in dt-bindings/leds/common.h - $ref: "/schemas/types.yaml#/definitions/uint32" required: - compatible
'led' nodes should have a reference to LED common.yaml schema. Add it where missing and drop any duplicate properties. Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- 3 files changed, 7 insertions(+), 21 deletions(-)