diff mbox series

[2/2] dts: synquacer: Drop unused and undocumented GPIO 'base' property

Message ID 20221209024509.1920944-2-robh@kernel.org
State Accepted
Commit bd8851c5b4984ffb26f55872c4e086d91989bc9a
Headers show
Series [1/2] dts: synquacer: Drop unused and undocumented SPI properties | expand

Commit Message

Rob Herring (Arm) Dec. 9, 2022, 2:45 a.m. UTC
The 'base' GPIO controller property is unused in u-boot and Linux. It is
also not documented in the binding. So drop it.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Masahisa Kojima Dec. 9, 2022, 5:10 a.m. UTC | #1
+ Jassi

On Fri, 9 Dec 2022 at 11:45, Rob Herring <robh@kernel.org> wrote:
>
> The 'base' GPIO controller property is unused in u-boot and Linux. It is
> also not documented in the binding. So drop it.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/dts/synquacer-sc2a11.dtsi b/arch/arm/dts/synquacer-sc2a11.dtsi
> index 0dd2969b5e3c..7ba1cd1bee70 100644
> --- a/arch/arm/dts/synquacer-sc2a11.dtsi
> +++ b/arch/arm/dts/synquacer-sc2a11.dtsi
> @@ -497,7 +497,6 @@
>          gpio-controller;
>          #gpio-cells = <2>;
>          clocks = <&clk_apb>;
> -        base = <0>;

Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Regards,
Masahisa Kojima

>      };
>
>      exiu: interrupt-controller@510c0000 {
> --
> 2.35.1
>
Ilias Apalodimas Dec. 9, 2022, 7:41 a.m. UTC | #2
On Thu, Dec 08, 2022 at 08:45:09PM -0600, Rob Herring wrote:
> The 'base' GPIO controller property is unused in u-boot and Linux. It is
> also not documented in the binding. So drop it.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/dts/synquacer-sc2a11.dtsi b/arch/arm/dts/synquacer-sc2a11.dtsi
> index 0dd2969b5e3c..7ba1cd1bee70 100644
> --- a/arch/arm/dts/synquacer-sc2a11.dtsi
> +++ b/arch/arm/dts/synquacer-sc2a11.dtsi
> @@ -497,7 +497,6 @@
>          gpio-controller;
>          #gpio-cells = <2>;
>          clocks = <&clk_apb>;
> -        base = <0>;
>      };
>  
>      exiu: interrupt-controller@510c0000 {
> -- 
> 2.35.1
> 
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Jassi Brar Dec. 9, 2022, 7:38 p.m. UTC | #3
On Thu, 8 Dec 2022 at 23:10, Masahisa Kojima <masahisa.kojima@linaro.org> wrote:
>
> + Jassi
>
> On Fri, 9 Dec 2022 at 11:45, Rob Herring <robh@kernel.org> wrote:
> >
> > The 'base' GPIO controller property is unused in u-boot and Linux. It is
> > also not documented in the binding. So drop it.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  arch/arm/dts/synquacer-sc2a11.dtsi | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/dts/synquacer-sc2a11.dtsi b/arch/arm/dts/synquacer-sc2a11.dtsi
> > index 0dd2969b5e3c..7ba1cd1bee70 100644
> > --- a/arch/arm/dts/synquacer-sc2a11.dtsi
> > +++ b/arch/arm/dts/synquacer-sc2a11.dtsi
> > @@ -497,7 +497,6 @@
> >          gpio-controller;
> >          #gpio-cells = <2>;
> >          clocks = <&clk_apb>;
> > -        base = <0>;
>
> Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>
>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Tom Rini Jan. 3, 2023, 3:42 p.m. UTC | #4
On Thu, Dec 08, 2022 at 08:45:09PM -0600, Rob Herring wrote:

> The 'base' GPIO controller property is unused in u-boot and Linux. It is
> also not documented in the binding. So drop it.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/arm/dts/synquacer-sc2a11.dtsi b/arch/arm/dts/synquacer-sc2a11.dtsi
index 0dd2969b5e3c..7ba1cd1bee70 100644
--- a/arch/arm/dts/synquacer-sc2a11.dtsi
+++ b/arch/arm/dts/synquacer-sc2a11.dtsi
@@ -497,7 +497,6 @@ 
         gpio-controller;
         #gpio-cells = <2>;
         clocks = <&clk_apb>;
-        base = <0>;
     };
 
     exiu: interrupt-controller@510c0000 {