diff mbox series

[PATCH-for-8.0,v3,1/2] physmem: Remove unused "exec/translate-all.h"

Message ID 20221209110631.59031-2-philmd@linaro.org
State New
Headers show
Series physmem: Remove trace events from trace-root.h | expand

Commit Message

Philippe Mathieu-Daudé Dec. 9, 2022, 11:06 a.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 softmmu/physmem.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Peter Maydell Dec. 9, 2022, 11:43 a.m. UTC | #1 
On Fri, 9 Dec 2022 at 11:07, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  softmmu/physmem.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
> index 1b606a3002..d562c0bb93 100644
> --- a/softmmu/physmem.c
> +++ b/softmmu/physmem.c
> @@ -58,7 +58,6 @@
>
>  #include "qemu/rcu_queue.h"
>  #include "qemu/main-loop.h"
> -#include "exec/translate-all.h"
>  #include "sysemu/replay.h"
>
>  #include "exec/memory-internal.h"
> --

physmem.c has a call to tb_check_watchpoint(), which is declared
in translate-all.h -- where does it get the prototype from if
the header isn't included any more ?

thanks
-- PMM
Philippe Mathieu-Daudé Dec. 9, 2022, 2:10 p.m. UTC | #2 
On 9/12/22 12:43, Peter Maydell wrote:
> On Fri, 9 Dec 2022 at 11:07, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   softmmu/physmem.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
>> index 1b606a3002..d562c0bb93 100644
>> --- a/softmmu/physmem.c
>> +++ b/softmmu/physmem.c
>> @@ -58,7 +58,6 @@
>>
>>   #include "qemu/rcu_queue.h"
>>   #include "qemu/main-loop.h"
>> -#include "exec/translate-all.h"
>>   #include "sysemu/replay.h"
>>
>>   #include "exec/memory-internal.h"
>> --
> 
> physmem.c has a call to tb_check_watchpoint(), which is declared
> in translate-all.h -- where does it get the prototype from if
> the header isn't included any more ?

Oops indeed, sorry.
diff mbox series

Patch

diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 1b606a3002..d562c0bb93 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -58,7 +58,6 @@ 
 
 #include "qemu/rcu_queue.h"
 #include "qemu/main-loop.h"
-#include "exec/translate-all.h"
 #include "sysemu/replay.h"
 
 #include "exec/memory-internal.h"