| Message ID | 20221202081647.3183870-3-uwu@icenowy.me |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rongpin RP-H6B support (and support for GL850G) | expand |
On 02/12/2022 09:16, Icenowy Zheng wrote: > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can > be bypassed) and an external reset pin. > > Add a device tree binding for its USB protocol part. The internal LDO is > not covered by this and can just be modelled as a fixed regulator. > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me> > --- > Changes in v2: > - Misc fixes suggested by Krzysztof, including property descriptions, > single-item "items" and fixing the example's gpio property. > - Fixed $id. > (...) > + > +examples: > + - | > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub: hub@1 { > + compatible = "usb5e3,608"; > + reg = <1>; > + reset-gpios = <&pio 7 2>; Use GPIO flags. What did you fix in the example? Best regards, Krzysztof
On 02/12/2022 17:54, Icenowy Zheng wrote: > 在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道： >> On 02/12/2022 09:16, Icenowy Zheng wrote: >>> The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that >>> features 4 downstream ports, an internal 5V-to-3.3V LDO regulator >>> (can >>> be bypassed) and an external reset pin. >>> >>> Add a device tree binding for its USB protocol part. The internal >>> LDO is >>> not covered by this and can just be modelled as a fixed regulator. >>> >>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me> >>> --- >>> Changes in v2: >>> - Misc fixes suggested by Krzysztof, including property >>> descriptions, >>> single-item "items" and fixing the example's gpio property. >>> - Fixed $id. >>> >> (...) >> >>> + >>> +examples: >>> + - | >>> + usb { >>> + dr_mode = "host"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + hub: hub@1 { >>> + compatible = "usb5e3,608"; >>> + reg = <1>; >>> + reset-gpios = <&pio 7 2>; >> >> Use GPIO flags. What did you fix in the example? > > It used to be here, but using it needs another include, which I don't > think it necessary here. The header is necessary for the flags... > > Maybe I should just drop this line in the example? It's useful. The example should be rather complete, not just compatible and reg. Different problem - you miss maxItems for the GPIOs. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml new file mode 100644 index 000000000000..966462ca6acb --- /dev/null +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Genesys Logic GL850G USB 2.0 hub controller + +maintainers: + - Icenowy Zheng <uwu@icenowy.me> + +allOf: + - $ref: usb-device.yaml# + +properties: + compatible: + enum: + - usb5e3,608 + + reg: true + + reset-gpios: + description: GPIO controlling the RESET# pin. + + vdd-supply: + description: + the regulator that provides 3.3V core power to the hub. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + usb { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + hub: hub@1 { + compatible = "usb5e3,608"; + reg = <1>; + reset-gpios = <&pio 7 2>; + }; + };
The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can be bypassed) and an external reset pin. Add a device tree binding for its USB protocol part. The internal LDO is not covered by this and can just be modelled as a fixed regulator. Signed-off-by: Icenowy Zheng <uwu@icenowy.me> --- Changes in v2: - Misc fixes suggested by Krzysztof, including property descriptions, single-item "items" and fixing the example's gpio property. - Fixed $id. .../bindings/usb/genesys,gl850g.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/genesys,gl850g.yaml