| Message ID | 20221125112201.240178-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 | expand |
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 25 November 2022 16:52 > To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar > <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P > <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>; > Sam Protsenko <semen.protsenko@linaro.org> > Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from > syscon > > Split Samsung Exynos SoC SYSREG bindings to own file to narrow the bindings > and do not allow other parts of syscon.yaml. This allows further customization > of Samsung SoC bindings. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Sriranjani P <sriranjani.p@samsung.com> > Cc: Chanho Park <chanho61.park@samsung.com> > Cc: Sam Protsenko <semen.protsenko@linaro.org> > --- We agree for add separate YAML for Samsung Exynos and hence I think we can go ahead and add separate yaml for Tesla FSD. Reviewed-by: Sriranjani P <sriranjani.p@samsung.com> > .../devicetree/bindings/mfd/syscon.yaml | 6 --- > .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++ > 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644 > Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml > b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 1b01bd010431..b73ba1ea08f7 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -64,12 +64,6 @@ properties: > - rockchip,rk3568-qos > - rockchip,rk3588-qos > - rockchip,rv1126-qos > - - samsung,exynos3-sysreg > - - samsung,exynos4-sysreg > - - samsung,exynos5-sysreg > - - samsung,exynos5433-sysreg > - - samsung,exynos850-sysreg > - - samsung,exynosautov9-sysreg > > - const: syscon > > diff --git > a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg.yaml > b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysreg.yaml > new file mode 100644 > index 000000000000..68064a5e339c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- > sysre > +++ g.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > +--- > +$id: > +https://protect2.fireeye.com/v1/url?k=83e9bb90-e2921107-83e830df- > 74fe48 > +60001d-5ef78ea8b86e70d7&q=1&e=8db037ae-b28c-44df-a71b- > 6e7c367bb9d6&u=ht > +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung% > 2Cexynos- > +sysreg.yaml%23 > +$schema: > +https://protect2.fireeye.com/v1/url?k=84a37bbf-e5d8d128-84a2f0f0-74fe48 > +60001d-bf5bdaa08b35d382&q=1&e=8db037ae-b28c-44df-a71b- > 6e7c367bb9d6&u=ht > +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: Samsung Exynos SoC series System Registers (SYSREG) > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - samsung,exynos3-sysreg > + - samsung,exynos4-sysreg > + - samsung,exynos5-sysreg > + - samsung,exynos5433-sysreg > + - samsung,exynos850-sysreg > + - samsung,exynosautov9-sysreg > + - const: syscon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + system-controller@10010000 { > + compatible = "samsung,exynos4-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; > -- > 2.34.1
On 25/11/2022 18:06, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: Friday, November 25, 2022 4:52 PM >> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>; >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar >> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> samsung-soc@vger.kernel.org >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P >> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>; >> Sam Protsenko <semen.protsenko@linaro.org> >> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add > dedicated >> SYSREG compatibles to Exynos5433 >> >> Exynos5433 has several different SYSREGs, so use dedicated compatibles for >> them. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> Cc: Sriranjani P <sriranjani.p@samsung.com> >> Cc: Chanho Park <chanho61.park@samsung.com> >> Cc: Sam Protsenko <semen.protsenko@linaro.org> >> --- >> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> index 68064a5e339c..42357466005e 100644 >> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysre >> +++ g.yaml >> @@ -17,10 +17,21 @@ properties: >> - samsung,exynos3-sysreg >> - samsung,exynos4-sysreg >> - samsung,exynos5-sysreg >> - - samsung,exynos5433-sysreg >> - samsung,exynos850-sysreg >> - samsung,exynosautov9-sysreg >> - const: syscon >> + - items: >> + - enum: >> + - samsung,exynos5433-cam0-sysreg >> + - samsung,exynos5433-cam1-sysreg >> + - samsung,exynos5433-disp-sysreg >> + - samsung,exynos5433-fsys-sysreg >> + - const: samsung,exynos5433-sysreg >> + - const: syscon >> + - items: >> + - const: samsung,exynos5433-sysreg >> + - const: syscon >> + deprecated: true > Any reason to add "deprecated: true" here for above compatible? Because it should be used alone as unspecific. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index bd6a354b9cb5..6976e45aa769 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -1118,22 +1118,26 @@ hdmiphy: hdmiphy@13af0000 { }; syscon_disp: syscon@13b80000 { - compatible = "samsung,exynos5433-sysreg", "syscon"; + compatible = "samsung,exynos5433-disp-sysreg", + "samsung,exynos5433-sysreg", "syscon"; reg = <0x13b80000 0x1010>; }; syscon_cam0: syscon@120f0000 { - compatible = "samsung,exynos5433-sysreg", "syscon"; + compatible = "samsung,exynos5433-cam0-sysreg", + "samsung,exynos5433-sysreg", "syscon"; reg = <0x120f0000 0x1020>; }; syscon_cam1: syscon@145f0000 { - compatible = "samsung,exynos5433-sysreg", "syscon"; + compatible = "samsung,exynos5433-cam1-sysreg", + "samsung,exynos5433-sysreg", "syscon"; reg = <0x145f0000 0x1038>; }; syscon_fsys: syscon@156f0000 { - compatible = "samsung,exynos5433-sysreg", "syscon"; + compatible = "samsung,exynos5433-fsys-sysreg", + "samsung,exynos5433-sysreg", "syscon"; reg = <0x156f0000 0x1044>; };
Exynos5433 has several different SYSREGs, so use dedicated compatibles for them. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Cc: Sriranjani P <sriranjani.p@samsung.com> Cc: Chanho Park <chanho61.park@samsung.com> Cc: Sam Protsenko <semen.protsenko@linaro.org> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)