| Message ID | 1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com |
|---|---|
| State | Accepted |
| Commit | e8679db2970f04ee5281c042977fff880a3c045a |
| Headers | show |
| Series | ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops | expand |
On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote: > Add __maybe_unused tag for system PM ops suspend and resume. > This is required to fix allmodconfig compilation issue. > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add system suspend/resume PM ops")'. I see you fixed that in v2, but this patch has already been applied ... Srinivasa, it seems a similar patch is needed for commit c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops"). For that you could use SYSTEM_SLEEP_PM_OPS() instead of the maybe_unused tags as suggested by Nathan. Mark, I appreciate you being responsive and picking patches quickly, it might help though to leave 'external' reviewers at least some time to provide their feedback :)
On Wed, Nov 30, 2022 at 05:07:46PM +0000, Matthias Kaehlcke wrote: > On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote: > > Add __maybe_unused tag for system PM ops suspend and resume. > > This is required to fix allmodconfig compilation issue. > > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") > This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add > system suspend/resume PM ops")'. I see you fixed that in v2, but this patch > has already been applied ... with the fixes tag already updated as I was applying it. > Mark, I appreciate you being responsive and picking patches quickly, it might > help though to leave 'external' reviewers at least some time to provide their > feedback :) There's a balance with hanging on for utterly trivial patches to get reviewed, especially in areas where reviews aren't relaible or consistent.
diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c index b96b85a..41db661 100644 --- a/sound/soc/qcom/lpass-sc7180.c +++ b/sound/soc/qcom/lpass-sc7180.c @@ -163,14 +163,14 @@ static int sc7180_lpass_exit(struct platform_device *pdev) return 0; } -static int sc7180_lpass_dev_resume(struct device *dev) +static int __maybe_unused sc7180_lpass_dev_resume(struct device *dev) { struct lpass_data *drvdata = dev_get_drvdata(dev); return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks); } -static int sc7180_lpass_dev_suspend(struct device *dev) +static int __maybe_unused sc7180_lpass_dev_suspend(struct device *dev) { struct lpass_data *drvdata = dev_get_drvdata(dev);
Add __maybe_unused tag for system PM ops suspend and resume. This is required to fix allmodconfig compilation issue. Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com> --- sound/soc/qcom/lpass-sc7180.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)