| Message ID | 20221129072022.41962-1-manivannan.sadhasivam@linaro.org |
|---|---|
| State | Accepted |
| Commit | a84160fbf4f2c8c5ffa588e19ea8f92eabd7ad17 |
| Headers | show |
| Series | soc: qcom: Select REMAP_MMIO for ICC_BWMON driver | expand |
On 29/11/2022 08:20, Manivannan Sadhasivam wrote: > ICC_BWMON driver uses REGMAP_MMIO for accessing the hardware registers. > So select the dependency in Kconfig. Without this, there will be errors > while building the driver with COMPILE_TEST only: > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, 29 Nov 2022 12:50:22 +0530, Manivannan Sadhasivam wrote: > ICC_BWMON driver uses REGMAP_MMIO for accessing the hardware registers. > So select the dependency in Kconfig. Without this, there will be errors > while building the driver with COMPILE_TEST only: > > ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/icc-bwmon.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1 > make: *** [Makefile:1944: modpost] Error 2 > > [...] Applied, thanks! [1/1] soc: qcom: Select REMAP_MMIO for ICC_BWMON driver commit: a84160fbf4f2c8c5ffa588e19ea8f92eabd7ad17 Best regards,
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 024e420f1bb7..75bfdb6f9705 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -236,6 +236,7 @@ config QCOM_ICC_BWMON tristate "QCOM Interconnect Bandwidth Monitor driver" depends on ARCH_QCOM || COMPILE_TEST select PM_OPP + select REGMAP_MMIO help Sets up driver monitoring bandwidth on various interconnects and based on that voting for interconnect bandwidth, adjusting their
ICC_BWMON driver uses REGMAP_MMIO for accessing the hardware registers. So select the dependency in Kconfig. Without this, there will be errors while building the driver with COMPILE_TEST only: ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/icc-bwmon.ko] undefined! make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1 make: *** [Makefile:1944: modpost] Error 2 Cc: <stable@vger.kernel.org> # 6.0 Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Fixes: b9c2ae6cac40 ("soc: qcom: icc-bwmon: Add bandwidth monitoring driver") Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)