mbox series

[v2,0/4] ufs: core: Always read the descriptors with max length

Message ID 1669045590-26101-1-git-send-email-Arthur.Simchaev@wdc.com
Headers show
Series ufs: core: Always read the descriptors with max length | expand

Message

Arthur Simchaev Nov. 21, 2022, 3:46 p.m. UTC 
v2--v3:
  Based on Bean's comments:
  1)Use kzalloc instead of kmalloc in ufshcd_set_active_icc_lvl - patch 2/4
  2)Delete  UFS_RPMB_UNIT definition - patch 2/4
  3)Delete len description - patch 3/4

v1--v2:
  Fix argument warning in ufshpb.c

Read any descriptor with a maximum size of QUERY_DESC_MAX_SIZE.
According to the spec the device rerurns the actual size.
Thus can improve code readability and save CPU cycles.
While at it, cleanup few leftovers around the descriptor size parameter.

Suggested-by: Bean Huo <beanhuo@micron.com>

Arthur Simchaev (4):
  ufs:core: Remove redundant wb check
  ufs:core: Remove redundant desc_size variable from hba
  ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
  ufs: core: Remove ufshcd_map_desc_id_to_length function

 drivers/ufs/core/ufs_bsg.c     |   7 +--
 drivers/ufs/core/ufshcd-priv.h |   3 --
 drivers/ufs/core/ufshcd.c      | 100 ++++++++++-------------------------------
 drivers/ufs/core/ufshpb.c      |   5 +--
 include/ufs/ufshcd.h           |   1 -
 5 files changed, 26 insertions(+), 90 deletions(-)

Comments

Bean Huo Nov. 23, 2022, 5:18 p.m. UTC | #1 
On Mon, 2022-11-21 at 17:46 +0200, Arthur Simchaev wrote:
> len argument is not used anymore in ufshcd_set_active_icc_lvl
> function.
> 
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> ---
>  drivers/ufs/core/ufshcd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 7456aa2..604348f 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7391,12 +7391,11 @@ static u32 ufshcd_get_max_icc_level(int
> sup_curr_uA, u32 start_scan,
>   * In case regulators are not initialized we'll return 0
>   * @hba: per-adapter instance
>   * @desc_buf: power descriptor buffer to extract ICC levels from.
> - * @len: length of desc_buff
>   *
>   * Returns calculated ICC level
>   */
>  static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> -						const u8 *desc_buf, int
> len)
> +						const u8 *desc_buf)


The Linux kernel already deprecates the 80 character per line coding
style, so you could keep one line here after removing len.


Reviewed-by: Bean Huo <beanhuo@micron.com>