diff mbox series

Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones

Message ID CecyZdAwliTFqNWeZYcBef--uL7SBwD_JGjv1i4pxjQPSDNpheMorDHT2dAiFVvcZbO2afBLIVjbE52fcUYLWtEroa68AkhM5GdJLHEsQ6c=@proton.me
State Superseded
Headers show
Series Bluetooth: btusb HCI_QUIRK_NO_SUSPEND_NOTIFIER causes kernel panic on CSR 5.0 clones | expand

Commit Message

Mihir Khatri Nov. 19, 2022, 6:07 p.m. UTC
It seems that setting the bit HCI_QUICK_NO_SUSPEND_NOTIFIER
on some fake CSR 5.0 clones can them to get registered 2 times
causing a kernel panic. After not setting the bit HCI_QUICK_NO_SUSPEND_NOTIFIER
everything works fine and no kernel panic can be observed.

Signed-off-by: Mihir Khatri <MihirKhatri@proton.me>

---

Comments

bluez.test.bot@gmail.com Nov. 19, 2022, 6:17 p.m. UTC | #1
This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: drivers/bluetooth/btusb.c:2267
error: drivers/bluetooth/btusb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e7914783d29e..f0d0224ca59e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2267,8 +2267,7 @@  static int btusb_setup_csr(struct hci_dev *hdev)
                set_bit(HCI_QUIRK_BROKEN_STORED_LINK_KEY, &hdev->quirks);
                set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks);
                set_bit(HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL, &hdev->quirks);
-               set_bit(HCI_QUIRK_NO_SUSPEND_NOTIFIER, &hdev->quirks);
                          
                /* Clear the reset quirk since this is not an actual
                 * early Bluetooth 1.1 device from CSR.
                 */