| Message ID | 20221117050126.2966714-1-kumaravel.thiagarajan@microchip.com |
|---|---|
| Headers | show |
| Series | 8250: microchip: pci1xxxx: Add driver for the pci1xxxx's quad-uart function | expand |
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Friday, November 18, 2022 4:14 PM > To: Tharunkumar Pasumarthi - I67821 > <Tharunkumar.Pasumarthi@microchip.com> > Subject: Re: [PATCH v5 tty-next 2/4] 8250: microchip: pci1xxxx: Add > serial8250_pci_setup_port definition in 8250_pcilib.c > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > Don't you have a dependency issue here? > > > > Okay, I will explain the need for the changes done in commit description. > > What I meant is that the 8250_pci patch should be _prerequisite_ to your > stuff and not otherwise. Hi Andy, So, do you suggest having these changes done as first patch of the patchset prior to patches specific for our driver? Thanks, Tharun Kumar P
On Sat, Nov 19, 2022 at 03:50:02AM +0000, Tharunkumar.Pasumarthi@microchip.com wrote: > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Friday, November 18, 2022 4:14 PM > > To: Tharunkumar Pasumarthi - I67821 <Tharunkumar.Pasumarthi@microchip.com> ... > > > > Don't you have a dependency issue here? > > > > > > Okay, I will explain the need for the changes done in commit description. > > > > What I meant is that the 8250_pci patch should be _prerequisite_ to your > > stuff and not otherwise. > > Hi Andy, > So, do you suggest having these changes done as first patch of the patchset prior to patches > specific for our driver? Yes.
On Fri, Nov 25, 2022 at 03:45:01PM +0000, Tharunkumar.Pasumarthi@microchip.com wrote: > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Thursday, November 17, 2022 1:55 PM ... > > > + case PCI_SUBDEVICE_ID_EFAR_PCI11414: > > > + irq_idx = idx; > > > + break; > > > > Try to make this entire switch-case more compact. It's possible. > > I am planning to use look-up table for this in-order to avoid computation > within switch case. Does this approach sound good? Maybe, it's you who decides, just show us the result and we will see.
pci1xxxx is a PCIe switch with a multi-function endpoint on one of its downstream ports. Quad-uart is one of the functions in the multi-function endpoint. This patch adds device driver for the quad-uart function and enumerates between 1 to 4 instances of uarts based on the PCIe subsystem device ID. The changes from v1->v2->v3->v4->v5 are mentioned in each patch in the patchset. Thanks to Andy Shevchenko, Ilpo Jarvinen, Chritophe JAILLET, Geert Uytterhoeven, Greg KH for their review comments. Kumaravel Thiagarajan (4): 8250: microchip: pci1xxxx: Add driver for quad-uart support. 8250: microchip: pci1xxxx: Add serial8250_pci_setup_port definition in 8250_pcilib.c 8250: microchip: pci1xxxx: Add RS485 support to quad-uart driver 8250: microchip: pci1xxxx: Add power management functions to quad-uart driver MAINTAINERS | 7 + drivers/tty/serial/8250/8250_pci.c | 24 +- drivers/tty/serial/8250/8250_pci1xxxx.c | 544 ++++++++++++++++++++++++ drivers/tty/serial/8250/8250_pcilib.c | 38 ++ drivers/tty/serial/8250/8250_pcilib.h | 9 + drivers/tty/serial/8250/8250_port.c | 8 + drivers/tty/serial/8250/Kconfig | 15 + drivers/tty/serial/8250/Makefile | 2 + include/uapi/linux/serial_core.h | 3 + 9 files changed, 628 insertions(+), 22 deletions(-) create mode 100644 drivers/tty/serial/8250/8250_pci1xxxx.c create mode 100644 drivers/tty/serial/8250/8250_pcilib.c create mode 100644 drivers/tty/serial/8250/8250_pcilib.h