Message ID | 20221116075207.32363-1-quic_ppareek@quicinc.com |
---|---|
Headers | show |
Series | arm64: dts: qcom: add dts for sa8540p-ride board | expand |
On Wed, Nov 16, 2022 at 01:22:07PM +0530, Parikshit Pareek wrote: > Introduce the Qualcomm SA8540P ride automotive platform, also known as > Qdrive-3 development board. > > This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh > regulators, debug UART, PMICs, remoteprocs and USB. > > The SA8540P ride contains four PM8450 PMICs. A separate DTSI file has > been created for PMIC, so that it can be used for future SA8540P based > boards. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > +&ufs_mem_hc { > + reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>; > + > + vcc-supply = <&vreg_l17c>; > + vcc-max-microamp = <800000>; > + vccq-supply = <&vreg_l6c>; > + vccq-max-microamp = <900000>; > + > + status = "disabled"; > +}; > + > +&ufs_mem_phy { > + vdda-phy-supply = <&vreg_l8g>; > + vdda-pll-supply = <&vreg_l3g>; > + > + status = "disabled"; > +}; Why are these disabled? This should be mentioned somewhere (e.g. commit message and/or comment) or you can drop the nodes until support is in place. Johan
On Wed, Nov 16, 2022 at 09:16:32AM +0100, Johan Hovold wrote: > On Wed, Nov 16, 2022 at 01:22:07PM +0530, Parikshit Pareek wrote: > > Introduce the Qualcomm SA8540P ride automotive platform, also known as > > Qdrive-3 development board. > > > > This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh > > regulators, debug UART, PMICs, remoteprocs and USB. > > > > The SA8540P ride contains four PM8450 PMICs. A separate DTSI file has > > been created for PMIC, so that it can be used for future SA8540P based > > boards. > > > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > > > +&ufs_mem_hc { > > + reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l17c>; > > + vcc-max-microamp = <800000>; > > + vccq-supply = <&vreg_l6c>; > > + vccq-max-microamp = <900000>; > > + > > + status = "disabled"; > > +}; > > + > > +&ufs_mem_phy { > > + vdda-phy-supply = <&vreg_l8g>; > > + vdda-pll-supply = <&vreg_l3g>; > > + > > + status = "disabled"; > > +}; > > Why are these disabled? This should be mentioned somewhere (e.g. commit > message and/or comment) or you can drop the nodes until support is in > place. My bad. Happened by mistake. > > Johan Regards, Parikshit Pareek
On Wed, Nov 16, 2022 at 01:22:07PM +0530, Parikshit Pareek wrote: > Introduce the Qualcomm SA8540P ride automotive platform, also known as > Qdrive-3 development board. > > This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh > regulators, debug UART, PMICs, remoteprocs and USB. > > The SA8540P ride contains four PM8450 PMICs. A separate DTSI file has > been created for PMIC, so that it can be used for future SA8540P based > boards. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Tested-by: Brian Masney <bmasney@redhat.com> > Reviewed-by: Brian Masney <bmasney@redhat.com> > Tested-by: Eric Chanudet <echanude@redhat.com> > Reviewed-by: Eric Chanudet <echanude@redhat.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/pm8450a.dtsi | 77 ++++++++ > arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 221 ++++++++++++++++++++++ > 3 files changed, 299 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm8450a.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-ride.dts > > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pm8150-rpmh-regulators"; > + qcom,pmic-id = "a"; > + vreg_l6c: ldo6 { > + regulator-name = "vreg_l6c"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + regulator-allowed-modes = > + <RPMH_REGULATOR_MODE_LPM > + RPMH_REGULATOR_MODE_HPM>; The indentation here is off, but I noticed that you've probably just copied that from the existing devicetree sources. I just sent a couple of patches to clean that up: https://lore.kernel.org/lkml/20221116102054.4673-1-johan+linaro@kernel.org/ You can drop the first newline and indent the continuation line properly using tabs (and spaces). > + regulator-allow-set-load; > + }; > + vreg_l17c: ldo17 { > + regulator-name = "vreg_l17c"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2504000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > + regulator-allowed-modes = > + <RPMH_REGULATOR_MODE_LPM > + RPMH_REGULATOR_MODE_HPM>; Here too. > + regulator-allow-set-load; > + }; > + }; Johan