| Message ID | 20221116145616.17884-1-luca@z3ntu.xyz |
|---|---|
| Headers | show |
| Series | Add a bunch of msm8953 dts files | expand |
On 16/11/2022 15:56, Luca Weiss wrote: > From: Julian Braha <julianbraha@gmail.com> > > Add device tree for the Motorola Moto G6 (ali) smartphone. This device > is based on Snapdragon 450 (sdm450) SoC which is a variant of MSM8953. > > Signed-off-by: Julian Braha <julianbraha@gmail.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sdm450-motorola-ali.dts | 256 ++++++++++++++++++ > 2 files changed, 257 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d7669a7cee9f..a0b537414593 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -115,6 +115,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-lenovo-thinkpad-x13s.dtb > dtb-$(CONFIG_ARCH_QCOM) += sda660-inforce-ifc6560.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm450-motorola-ali.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts b/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > new file mode 100644 > index 000000000000..62874306fc24 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > @@ -0,0 +1,256 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2020, The Linux Foundation. All rights reserved. > + */ > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > + > +/ { > + model = "Motorola Moto G6"; > + compatible = "motorola,ali", "qcom,sdm450"; > + chassis-type = "handset"; > + qcom,msm-id = <338 0>; > + qcom,board-id = <0x41 0xb1a0>, > + <0x42 0xb1a0>, > + <0x43 0xc100>, > + <0x42 0xb1b0>, > + <0x43 0xc200>, > + <0x44 0xc200>, > + <0x42 0xb200>, > + <0x43 0xb200>; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + key-volume-up { > + label = "volume_up"; > + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + }; > + > + reserved-memory { > + /delete-node/ memory@85b00000; Please assign it a label and delete the node by referencing it, otherwise we don't know what you're removing. > + memory@84300000 { > + no-map; > + reg = <0x0 0x84300000 0x0 0x2000000>; reg first, please. > + }; > + > + ramoops@ef000000 { > + compatible = "ramoops"; > + reg = <0x0 0xef000000 0x0 0xC0000>; No uppsercase hex, please. Konrad > + console-size = <0x40000>; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&hsusb_phy { > + vdd-supply = <&pm8953_l3>; > + vdda-pll-supply = <&pm8953_l7>; > + vdda-phy-dpdm-supply = <&pm8953_l13>; > + > + status = "okay"; > +}; > + > +&i2c_3 { > + status = "okay"; > + > + touchscreen@38 { > + compatible = "edt,edt-ft5406"; > + reg = <0x38>; > + interrupt-parent = <&tlmm>; > + interrupts = <65 IRQ_TYPE_EDGE_FALLING>; > + vcc-supply = <&pm8953_l10>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ts_int_active &ts_reset_active>; > + > + reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>; > + touchscreen-size-x = <1080>; > + touchscreen-size-y = <2160>; > + }; > +}; > + > +&pm8953_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + status = "okay"; > +}; > + > +&pmi8950_wled { > + qcom,num-strings = <3>; > + qcom,external-pfet; > + qcom,cabc; > + > + status = "okay"; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; > + > + vdd_s1-supply = <&vph_pwr>; > + vdd_s2-supply = <&vph_pwr>; > + vdd_s3-supply = <&vph_pwr>; > + vdd_s4-supply = <&vph_pwr>; > + vdd_s5-supply = <&vph_pwr>; > + vdd_s6-supply = <&vph_pwr>; > + vdd_s7-supply = <&vph_pwr>; > + vdd_l1-supply = <&pm8953_s3>; > + vdd_l2_l3-supply = <&pm8953_s3>; > + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; > + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; > + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; > + > + pm8953_s1: s1 { > + regulator-min-microvolt = <795000>; > + regulator-max-microvolt = <1081000>; > + }; > + > + pm8953_s3: s3 { > + regulator-min-microvolt = <1224000>; > + regulator-max-microvolt = <1224000>; > + }; > + > + pm8953_s4: s4 { > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <2050000>; > + }; > + > + pm8953_l1: l1 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1100000>; > + }; > + > + pm8953_l2: l2 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1225000>; > + }; > + > + pm8953_l3: l3 { > + regulator-min-microvolt = <925000>; > + regulator-max-microvolt = <925000>; > + }; > + > + pm8953_l5: l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l6: l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l7: l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + }; > + > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + pm8953_l9: l9 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8953_l10: l10 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l11: l11 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8953_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8953_l13: l13 { > + regulator-min-microvolt = <3125000>; > + regulator-max-microvolt = <3125000>; > + }; > + > + pm8953_l16: l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l17: l17 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l19: l19 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1350000>; > + }; > + > + pm8953_l22: l22 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l23: l23 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1225000>; > + }; > + }; > +}; > + > +&sdhc_1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on &sdc1_rclk_on>; > + pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off &sdc1_rclk_off>; > + > + status = "okay"; > +}; > + > +&sdhc_2 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <95 5>, <111 1>, <126 1>; > + > + ts_int_active: ts-int-active-state { > + pins = "gpio65"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + ts_reset_active: ts-reset-active-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <0x08>; > + bias-pull-up; > + }; > +}; > + > +&usb3 { > + status = "okay"; > +}; > + > +&usb3_dwc3 { > + dr_mode = "peripheral"; > +};
On 16/11/2022 15:56, Luca Weiss wrote: > From: Sireesh Kodali <sireeshkodali1@gmail.com> > > Add device tree for the Motorola G5 Plus (potter) smartphone. This > device is based on Snapdragon 625 (msm8953) SoC. > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8953-motorola-potter.dts | 306 ++++++++++++++++++ > 2 files changed, 307 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index a0b537414593..21a6a7b5a2cf 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -21,6 +21,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-grandmax.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > new file mode 100644 > index 000000000000..3957dabf651e > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dts > @@ -0,0 +1,306 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 The Linux Foundation. All rights reserved. > + */ > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > + > +/ { > + model = "Motorola G5 Plus"; > + compatible = "motorola,potter", "qcom,msm8953"; > + chassis-type = "handset"; > + qcom,msm-id = <293 0>; > + qcom,board-id = <0x46 0x83a0>; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer@90001000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x90001000 0 (2220 * 1920 * 3)>; > + > + width = <1080>; > + height = <1920>; > + stride = <(1080 * 3)>; > + format = "r8g8b8"; > + > + power-domains = <&gcc MDSS_GDSC>; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_key_default>; > + > + key-volume-up { > + label = "Volume Up"; > + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + }; > + > + reserved-memory { > + /delete-node/ memory@85b00000; Same comment as in 1/8. > + > + memory@84300000 { > + reg = <0x0 0x84300000 0x0 0x2000000>; > + no-map; > + }; > + > + memory@90001000 { > + reg = <0x0 0x90001000 0x0 (1080 * 1920 * 3)>; > + no-map; > + }; > + > + memory@aefd2000 { > + reg = <0x0 0xaefd2000 0x0 0x2e000>; > + no-map; > + }; > + > + memory@eefe4000 { > + reg = <0x0 0xeefe4000 0x0 0x1c000>; > + no-map; > + }; > + > + ramoops@ef000000 { > + compatible = "ramoops"; > + reg = <0x0 0xef000000 0x0 0x80000>; > + console-size = <0x40000>; > + ftrace-size = <0>; > + record-size = <0x3f800>; > + pmsg-size = <0x800>; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&hsusb_phy { > + vdd-supply = <&pm8953_l3>; > + vdda-pll-supply = <&pm8953_l7>; > + vdda-phy-dpdm-supply = <&pm8953_l13>; > + > + status = "okay"; > +}; > + > +&i2c_3 { > + status = "okay"; > + > + touchscreen@20 { > + reg = <0x20>; > + compatible = "syna,rmi4-i2c"; > + > + interrupt-parent = <&tlmm>; > + interrupts = <65 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ts_reset>; > + > + vdd-supply = <&pm8953_l22>; > + vio-supply = <&pm8953_l6>; > + > + syna,reset-delay-ms = <200>; > + syna,startup-delay-ms = <500>; > + }; > +}; > + > +&pm8953_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + status = "okay"; > +}; > + > +&pmi8950_wled { > + qcom,current-limit-microamp = <25000>; > + qcom,num-strings = <3>; > + qcom,external-pfet; > + qcom,cabc; > + > + status = "okay"; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; > + vdd_s1-supply = <&vph_pwr>; > + vdd_s2-supply = <&vph_pwr>; > + vdd_s3-supply = <&vph_pwr>; > + vdd_s4-supply = <&vph_pwr>; > + vdd_s5-supply = <&vph_pwr>; > + vdd_s6-supply = <&vph_pwr>; > + vdd_s7-supply = <&vph_pwr>; > + vdd_l1-supply = <&pm8953_s3>; > + vdd_l2_l3-supply = <&pm8953_s3>; > + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; > + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; > + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; > + > + pm8953_s1: s1 { > + regulator-min-microvolt = <863000>; > + regulator-max-microvolt = <1152000>; > + }; > + > + pm8953_s3: s3 { > + regulator-min-microvolt = <1224000>; > + regulator-max-microvolt = <1224000>; > + }; > + > + pm8953_s4: s4 { > + regulator-min-microvolt = <1896000>; > + regulator-max-microvolt = <2048000>; > + }; > + > + pm8953_l1: l1 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1100000>; > + }; > + > + pm8953_l2: l2 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + }; > + > + pm8953_l3: l3 { > + regulator-min-microvolt = <925000>; > + regulator-max-microvolt = <925000>; > + regulator-allow-set-load; > + }; > + > + pm8953_l5: l5 { > + /* May fix sdcard detection */ So does it, or does it not? Please keep the boolean regulator properties below min/max. Konrad > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l6: l6 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l7: l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + }; > + > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + pm8953_l9: l9 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8953_l10: l10 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l11: l11 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l13: l13 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3125000>; > + }; > + > + pm8953_l15: l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l16: l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l17: l17 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l19: l19 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1350000>; > + }; > + > + pm8953_l22: l22 { > + regulator-always-on; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l23: l23 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1225000>; > + }; > + }; > +}; > + > +&sdhc_1 { > + vmmc-supply = <&pm8953_l8>; > + vqmmc-supply = <&pm8953_l5>; > + > + status = "okay"; > +}; > + > +&sdhc_2 { > + cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + vmmc-supply = <&pm8953_l11>; > + vqmmc-supply = <&pm8953_l12>; > + > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <1 2>, <96 4>, <111 1>, <126 1>; > + > + ts_reset: ts-reset-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > +}; > + > +&usb3 { > + status = "okay"; > +}; > + > +&usb3_dwc3 { > + dr_mode = "peripheral"; > +};
On 16/11/2022 15:56, Luca Weiss wrote: > From: Eugene Lepshy <fekz115@gmail.com> > > Add device tree for the Xiaomi Redmi 5 Plus (vince) smartphone. This > device is based on Snapdragon 625 (msm8953) SoC. > > Signed-off-by: Eugene Lepshy <fekz115@gmail.com> > Co-developed-by: Gianluca Boiano <morf3089@gmail.com> > Signed-off-by: Gianluca Boiano <morf3089@gmail.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/msm8953-xiaomi-vince.dts | 330 ++++++++++++++++++ > 2 files changed, 331 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 9517638b2fdd..bed490c095dd 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -25,6 +25,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-tissot.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-vince.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts > new file mode 100644 > index 000000000000..da029aaa99a1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dts > @@ -0,0 +1,330 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > +#include <dt-bindings/leds/common.h> > + > +/ { > + model = "Xiaomi Redmi 5 Plus"; > + compatible = "xiaomi,vince", "qcom,msm8953"; > + chassis-type = "handset"; > + qcom,msm-id = <293 0>; > + qcom,board-id= <0x1000b 0x08>; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_key_default>; > + > + key-volume-up { > + label = "volume_up"; > + linux,code = <KEY_VOLUMEUP>; > + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + reserved-memory { > + /delete-node/ memory@85b00000; > + memory@84a00000 { > + reg = <0x0 0x84a00000 0x0 0x1900000>; > + no-map; > + }; > + > + cont_splash_mem: memory@90001000 { > + reg = <0x0 0x90001000 0x0 (1080 * 2160 * 3)>; > + no-map; > + }; > + > + /delete-node/ memory@8d600000; > + adsp_fw_mem: memory@8d600000 { > + reg = <0x0 0x8d600000 0x0 0x1200000>; > + no-map; > + }; > + > + /delete-node/ memory@8e700000; > + wcnss_fw_mem: memory@8e800000 { > + reg = <0x0 0x8e800000 0x0 0x700000>; > + no-map; > + }; > + > + ramoops@9ff00000 { > + compatible = "ramoops"; > + reg = <0x0 0x9ff00000 0x0 0x100000>; > + record-size = <0x1000>; > + console-size = <0x80000>; > + ftrace-size = <0x1000>; > + pmsg-size = <0x8000>; > + }; > + }; > + > + i2c-gpio { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm 14 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm 15 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; > + i2c-gpio,delay-us = <2>; /* ~100 kHz */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + imu@6a { > + compatible = "st,lsm6dsl"; > + reg = <0x6a>; > + vdd-supply = <&pm8953_l10>; > + vddio-supply = <&pm8953_l6>; > + mount-matrix = "1", "0", "0", > + "0", "-1", "0", > + "0", "0", "1"; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&hsusb_phy { > + vdd-supply = <&pm8953_l3>; > + vdda-pll-supply = <&pm8953_l7>; > + vdda-phy-dpdm-supply = <&pm8953_l13>; > + > + status = "okay"; > +}; > + > +&i2c_2 { > + status = "okay"; > + > + led-controller@45 { > + compatible = "awinic,aw2013"; > + reg = <0x45>; > + > + vcc-supply = <&pm8953_l10>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + led-max-microamp = <5000>; > + function = LED_FUNCTION_INDICATOR; > + color = <LED_COLOR_ID_WHITE>; > + }; > + }; > +}; > + > +&i2c_3 { > + status = "okay"; > + > + touchscreen@20 { > + reg = <0x20>; > + compatible = "syna,rmi4-i2c"; > + interrupts-parent = <&tlmm>; > + interrupts-extended = <&tlmm 65 IRQ_TYPE_EDGE_FALLING>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + vdd-supply = <&pm8953_l10>; > + vio-supply = <&pm8953_l6>; > + > + pinctrl-names = "init", "suspend"; > + pinctrl-0 = <&ts_reset_active &ts_int_active>; > + pinctrl-1 = <&ts_reset_suspend &ts_int_suspend>; > + syna,reset-delay-ms = <200>; > + syna,startup-delay-ms = <500>; > + > + rmi4-f01@1 { > + reg = <0x01>; > + syna,nosleep-mode = <1>; > + }; > + > + rmi4-f12@12 { > + reg = <0x12>; > + syna,rezero-wait-ms = <20>; > + syna,sensor-type = <1>; > + touchscreen-x-mm = <68>; > + touchscreen-y-mm = <122>; > + }; > + }; > +}; > + > +&pm8953_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + status = "okay"; > +}; > + > +&pmi8950_wled { > + qcom,current-limit-microamp = <20000>; > + qcom,ovp-millivolt = <29600>; > + qcom,num-strings = <2>; > + qcom,external-pfet; > + qcom,cabc; > + > + status = "okay"; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; > + vdd_s1-supply = <&vph_pwr>; > + vdd_s2-supply = <&vph_pwr>; > + vdd_s3-supply = <&vph_pwr>; > + vdd_s4-supply = <&vph_pwr>; > + vdd_s5-supply = <&vph_pwr>; > + vdd_s6-supply = <&vph_pwr>; > + vdd_s7-supply = <&vph_pwr>; > + vdd_l1-supply = <&pm8953_s3>; > + vdd_l2_l3-supply = <&pm8953_s3>; > + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; > + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; > + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; > + > + pm8953_s1: s1 { > + regulator-min-microvolt = <870000>; > + regulator-max-microvolt = <1156000>; > + }; > + > + pm8953_s3: s3 { > + regulator-min-microvolt = <984000>; > + regulator-max-microvolt = <1224000>; > + }; Please add a newline after each node. (+delete nodes by referencing their label, check licensing and check if i2c-gpio is necessary as in the rest of the patches) Konrad > + pm8953_s4: s4 { > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <2050000>; > + }; > + pm8953_l1: l1 { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1100000>; > + }; > + pm8953_l2: l2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1225000>; > + }; > + pm8953_l3: l3 { > + regulator-min-microvolt = <925000>; > + regulator-max-microvolt = <925000>; > + }; > + pm8953_l5: l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + pm8953_l6: l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + pm8953_l7: l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + }; > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + pm8953_l9: l9 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + }; > + pm8953_l10: l10 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + }; > + pm8953_l11: l11 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + }; > + pm8953_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + pm8953_l13: l13 { > + regulator-min-microvolt = <3125000>; > + regulator-max-microvolt = <3125000>; > + }; > + pm8953_l16: l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + pm8953_l17: l17 { > + regulator-min-microvolt = <2750000>; > + regulator-max-microvolt = <2850000>; > + }; > + pm8953_l19: l19 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1380000>; > + }; > + pm8953_l22: l22 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + }; > + pm8953_l23: l23 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1225000>; > + }; > + }; > +}; > + > +&sdhc_1 { > + status = "okay"; > +}; > + > +&sdhc_2 { > + vmmc-supply = <&pm8953_l11>; > + vqmmc-supply = <&pm8953_l12>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <0 4>, <16 4>, <135 4>; > + > + ts_reset_active: ts-reset-active-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + ts_reset_suspend: ts-reset-suspend-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > + ts_int_active: ts-int-active-state { > + pins = "gpio65"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + ts_int_suspend: ts-int-suspend-state { > + pins = "gpio65"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + }; > +}; > + > +&uart_0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart_console_active>; > + > + status = "okay"; > +}; > + > +&usb3 { > + status = "okay"; > +}; > + > +&usb3_dwc3 { > + dr_mode = "peripheral"; > +};
On 16/11/2022 15:56, Luca Weiss wrote: > From: Gabriela David <ultracoolguy@disroot.org> > > Add device tree for the Motorola G7 Power (ocean) smartphone. This > device is based on Snapdragon 632 (sdm632) SoC which is a variant of > MSM8953. > > Signed-off-by: Gabriela David <ultracoolguy@disroot.org> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sdm632-motorola-ocean.dts | 287 ++++++++++++++++++ > 2 files changed, 288 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sdm632-motorola-ocean.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index bed490c095dd..d125ea98ce3b 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -126,6 +126,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-voyager.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm632-fairphone-fp3.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm632-motorola-ocean.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm636-sony-xperia-ganges-mermaid.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-lavender.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm632-motorola-ocean.dts b/arch/arm64/boot/dts/qcom/sdm632-motorola-ocean.dts > new file mode 100644 > index 000000000000..7ec7ec0ef2d5 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm632-motorola-ocean.dts > @@ -0,0 +1,287 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/dts-v1/; > + > +#include "sdm632.dtsi" > +#include "pm8953.dtsi" > +#include <dt-bindings/leds/common.h> > + > +/ { > + model = "Motorola G7 Power"; > + compatible = "motorola,ocean", "qcom,sdm632"; > + chassis-type = "handset"; > + qcom,msm-id = <349 0>; > + qcom,board-id = <0x141 0xc100>; > + qcom,pmic-id = <0x10016 0x25 0x00 0x00>; > + > + backlight: backlight { > + compatible = "led-backlight"; > + leds = <&led>; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + framebuffer@90001000 { > + compatible = "simple-framebuffer"; > + reg = <0 0x90001000 0 (720 * 1520 * 3)>; > + > + width = <720>; > + height = <1520>; > + stride = <(720 * 3)>; > + format = "r8g8b8"; > + > + power-domains = <&gcc MDSS_GDSC>; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_key_default>; > + > + key-volume-up { > + label = "Volume Up"; > + gpios = <&tlmm 85 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + }; > + > + reserved-memory { > + /delete-node/ memory@85b00000; > + > + memory@84300000 { > + reg = <0x0 0x84300000 0x0 0x2000000>; > + no-map; > + }; > + > + memory@90001000 { > + reg = <0x0 0x90001000 0x0 (720 * 1520 * 3)>; > + no-map; > + }; > + > + memory@eefa1800 { > + reg = <0x00 0xeefa1800 0x00 0x5e800>; > + no-map; > + }; > + > + ramoops@ef000000 { > + compatible = "ramoops"; > + reg = <0x0 0xef000000 0x0 0xbf800>; > + console-size = <0x40000>; > + pmsg-size = <0x40000>; > + record-size = <0x3f800>; > + }; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&hsusb_phy { > + vdd-supply = <&pm8953_l3>; > + vdda-pll-supply = <&pm8953_l7>; > + vdda-phy-dpdm-supply = <&pm8953_l13>; > + > + status = "okay"; > +}; > + > +&i2c_3 { > + status = "okay"; > + > + touchscreen@41 { > + compatible = "ilitek,ili2117"; > + reg = <0x41>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <65 IRQ_TYPE_EDGE_FALLING>; > + > + touchscreen-inverted-x; > + }; > +}; > + > +&i2c_5 { > + status = "okay"; > + > + led-controller@36 { > + compatible = "ti,lm3697"; > + reg = <0x36>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led: led@1 { > + reg = <1>; > + default-trigger = "backlight"; > + function = LED_FUNCTION_BACKLIGHT; > + led-sources = <0 1 2>; > + }; > + }; > +}; > + > +&pm8953_resin { > + linux,code = <KEY_VOLUMEDOWN>; > + status = "okay"; > +}; > + > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; > + > + vdd_l1-supply = <&pm8953_s3>; > + vdd_l2_l3-supply = <&pm8953_s3>; > + vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>; > + vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>; > + vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>; > + > + pm8953_s3: s3 { > + regulator-min-microvolt = <984000>; > + regulator-max-microvolt = <1240000>; > + }; > + > + pm8953_s4: s4 { > + regulator-min-microvolt = <1036000>; > + regulator-max-microvolt = <2040000>; > + }; > + > + pm8953_l1: l1 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1050000>; > + }; > + > + pm8953_l2: l2 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1175000>; > + }; > + > + pm8953_l3: l3 { > + regulator-min-microvolt = <925000>; > + regulator-max-microvolt = <925000>; > + regulator-allow-set-load; > + }; > + > + pm8953_l5: l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l6: l6 { // other ocean models use l22 instead /* C-style comments, please */ + please clarify what it is used for + all the comments I made to the previous 6 DTs Konrad > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l7: l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + }; > + > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + pm8953_l9: l9 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + pm8953_l10: l10 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + pm8953_l11: l11 { > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8953_l12: l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + pm8953_l13: l13 { > + regulator-min-microvolt = <3125000>; > + regulator-max-microvolt = <3125000>; > + }; > + > + pm8953_l16: l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + pm8953_l17: l17 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + }; > + > + pm8953_l18: l18 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2700000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + pm8953_l19: l19 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1350000>; > + }; > + > + pm8953_l22: l22 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + pm8953_l23: l23 { > + regulator-min-microvolt = <975000>; > + regulator-max-microvolt = <1225000>; > + }; > + }; > +}; > + > +&sdhc_1 { > + vmmc-supply = <&pm8953_l8>; > + vqmmc-supply = <&pm8953_l5>; > + > + status = "okay"; > +}; > + > +&sdhc_2 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + vmmc-supply = <&pm8953_l11>; > + vqmmc-supply = <&pm8953_l12>; > + > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <96 4>; > +}; > + > +&usb3 { > + status = "okay"; > +}; > + > +&usb3_dwc3 { > + dr_mode = "peripheral"; > +};
On 16/11/2022 15:56, Luca Weiss wrote: > From: Julian Braha <julianbraha@gmail.com> > > Add device tree for the Motorola Moto G6 (ali) smartphone. This device > is based on Snapdragon 450 (sdm450) SoC which is a variant of MSM8953. > > Signed-off-by: Julian Braha <julianbraha@gmail.com> Missing SoB. Please run scripts/checkpatch.pl and fix reported warnings. > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/sdm450-motorola-ali.dts | 256 ++++++++++++++++++ > 2 files changed, 257 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d7669a7cee9f..a0b537414593 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -115,6 +115,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-lenovo-thinkpad-x13s.dtb > dtb-$(CONFIG_ARCH_QCOM) += sda660-inforce-ifc6560.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sdm450-motorola-ali.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-ganges-kirin.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-discovery.dtb > dtb-$(CONFIG_ARCH_QCOM) += sdm630-sony-xperia-nile-pioneer.dtb > diff --git a/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts b/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > new file mode 100644 > index 000000000000..62874306fc24 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dts > @@ -0,0 +1,256 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2020, The Linux Foundation. All rights reserved. > + */ > +/dts-v1/; > + > +#include "msm8953.dtsi" > +#include "pm8953.dtsi" > +#include "pmi8950.dtsi" > + > +/ { > + model = "Motorola Moto G6"; > + compatible = "motorola,ali", "qcom,sdm450"; > + chassis-type = "handset"; > + qcom,msm-id = <338 0>; > + qcom,board-id = <0x41 0xb1a0>, > + <0x42 0xb1a0>, > + <0x43 0xc100>, > + <0x42 0xb1b0>, > + <0x43 0xc200>, > + <0x44 0xc200>, > + <0x42 0xb200>, > + <0x43 0xb200>; Both properties are not allowed, unless exception list is extended. Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof