| Message ID | 20221104142204.156333-2-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Qualcomm Ramp Controller and MSM8976 config | expand |
On 04/11/2022 10:22, AngeloGioacchino Del Regno wrote: > Document bindings for the Qualcomm Ramp Controller, found on various > legacy Qualcomm SoCs. Subject: drop second "bindings" word. One in prefix (dt-bindings) is enough. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- With above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 04 Nov 2022 15:22:03 +0100, AngeloGioacchino Del Regno wrote: > Document bindings for the Qualcomm Ramp Controller, found on various > legacy Qualcomm SoCs. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../qcom/qcom,msm8976-ramp-controller.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.example.dtb: power-controller@b014000: '#power-domain-cells' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/power-domain.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Il 04/11/22 18:54, Rob Herring ha scritto: > > On Fri, 04 Nov 2022 15:22:03 +0100, AngeloGioacchino Del Regno wrote: >> Document bindings for the Qualcomm Ramp Controller, found on various >> legacy Qualcomm SoCs. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../qcom/qcom,msm8976-ramp-controller.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.example.dtb: power-controller@b014000: '#power-domain-cells' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/power-domain.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > I'm unsure about what I should do about this one. This is a power-controller, but does *not* need any #power-domain-cells, as it is standalone and doesn't require being attached to anything. Any hints? Thanks, Angelo
On 11/11/2022 11:05, AngeloGioacchino Del Regno wrote: > Il 04/11/22 18:54, Rob Herring ha scritto: >> >> On Fri, 04 Nov 2022 15:22:03 +0100, AngeloGioacchino Del Regno wrote: >>> Document bindings for the Qualcomm Ramp Controller, found on various >>> legacy Qualcomm SoCs. >>> >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> .../qcom/qcom,msm8976-ramp-controller.yaml | 37 +++++++++++++++++++ >>> 1 file changed, 37 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.example.dtb: power-controller@b014000: '#power-domain-cells' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/power-domain.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/patch/ >> >> This check can fail if there are any dependencies. The base for a patch >> series is generally the most recent rc1. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. >> > > I'm unsure about what I should do about this one. > This is a power-controller, but does *not* need any #power-domain-cells, as it is > standalone and doesn't require being attached to anything. power-domain-cells are for power domain providers, not consumers. The generic binding expect that nodes called power-controller are exactly like that. Solutions could be: 1. Rename the node to something else. I cannot deduct the type of the device based on description. What is "sequence ID" and how is it even closely related to power control? 2. Narrow the node name in power-domain.yaml which would require changes in multiple DTS and bindings. 3. Do not require power-domain-cells for power-controllers, only for power-domains. Best regards, Krzysztof
Il 15/11/22 14:36, Krzysztof Kozlowski ha scritto: > On 11/11/2022 11:05, AngeloGioacchino Del Regno wrote: >> Il 04/11/22 18:54, Rob Herring ha scritto: >>> >>> On Fri, 04 Nov 2022 15:22:03 +0100, AngeloGioacchino Del Regno wrote: >>>> Document bindings for the Qualcomm Ramp Controller, found on various >>>> legacy Qualcomm SoCs. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>>> --- >>>> .../qcom/qcom,msm8976-ramp-controller.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.example.dtb: power-controller@b014000: '#power-domain-cells' is a required property >>> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/power-domain.yaml >>> >>> doc reference errors (make refcheckdocs): >>> >>> See https://patchwork.ozlabs.org/patch/ >>> >>> This check can fail if there are any dependencies. The base for a patch >>> series is generally the most recent rc1. >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to >>> date: >>> >>> pip3 install dtschema --upgrade >>> >>> Please check and re-submit. >>> >> >> I'm unsure about what I should do about this one. >> This is a power-controller, but does *not* need any #power-domain-cells, as it is >> standalone and doesn't require being attached to anything. > > power-domain-cells are for power domain providers, not consumers. The > generic binding expect that nodes called power-controller are exactly > like that. > > Solutions could be: > 1. Rename the node to something else. I cannot deduct the type of the > device based on description. What is "sequence ID" and how is it even > closely related to power control? This uC is mainly controlling DCVS, automagically plays with voltages for each ramp up/down step and from what I understand also decides to shut down or bring up *power* to "certain clocks" before ungating (CPU related, mainly big cluster). This also interacts with LMH - setting the LMH part makes it possible to later use CPR (otherwise CPR errors out internally and won't start, as it requires this controller, SAW and LMH to be set up in order to work). What I've seen is that without it I can't bring up the big cluster at all, not even at minimum frequency, as the HF2PLL (a clock source for that cluster) will not power up. All it takes is to initialize these params and start the controller, then everything goes as it should. If you're wondering why my explanation may not be particularly satisfying, that's because downstream contains practically no information about this one, apart from a bunch of lines of code and because this controller is just a big black box. > > 2. Narrow the node name in power-domain.yaml which would require changes > in multiple DTS and bindings. > > 3. Do not require power-domain-cells for power-controllers, only for > power-domains. > Solutions 2 and 3... well, I don't think that this would be really feasible as I envision this being the one and only driver that will ever require that kind of thing. Also, this programming was later moved to bootloaders and the only SoCs that will ever require this are MSM8956/76, MSM8953 and.. I think MSM8952 as well, but nothing more. Even if I can imagine the answer, I'm still tempted to ask: can we eventually just name it ramp-controller@xxxx or qcom-rc@xxxx or something "special" like that to overcome to this binding issue? Regards, Angelo
On 15/11/2022 15:44, AngeloGioacchino Del Regno wrote: >>>> Please check and re-submit. >>>> >>> >>> I'm unsure about what I should do about this one. >>> This is a power-controller, but does *not* need any #power-domain-cells, as it is >>> standalone and doesn't require being attached to anything. >> >> power-domain-cells are for power domain providers, not consumers. The >> generic binding expect that nodes called power-controller are exactly >> like that. >> >> Solutions could be: >> 1. Rename the node to something else. I cannot deduct the type of the >> device based on description. What is "sequence ID" and how is it even >> closely related to power control? > > This uC is mainly controlling DCVS, automagically plays with voltages for > each ramp up/down step and from what I understand also decides to shut down > or bring up *power* to "certain clocks" before ungating (CPU related, mainly > big cluster). > This also interacts with LMH - setting the LMH part makes it possible to > later use CPR (otherwise CPR errors out internally and won't start, as it > requires this controller, SAW and LMH to be set up in order to work). > > What I've seen is that without it I can't bring up the big cluster at all, > not even at minimum frequency, as the HF2PLL (a clock source for that cluster) > will not power up. > All it takes is to initialize these params and start the controller, then > everything goes as it should. > > If you're wondering why my explanation may not be particularly satisfying, > that's because downstream contains practically no information about this > one, apart from a bunch of lines of code and because this controller is > just a big black box. > >> >> 2. Narrow the node name in power-domain.yaml which would require changes >> in multiple DTS and bindings. >> >> 3. Do not require power-domain-cells for power-controllers, only for >> power-domains. >> > > Solutions 2 and 3... well, I don't think that this would be really feasible > as I envision this being the one and only driver that will ever require > that kind of thing. > Also, this programming was later moved to bootloaders and the only SoCs that > will ever require this are MSM8956/76, MSM8953 and.. I think MSM8952 as well, > but nothing more. > > Even if I can imagine the answer, I'm still tempted to ask: can we eventually > just name it ramp-controller@xxxx or qcom-rc@xxxx or something "special" like > that to overcome to this binding issue? So maybe "cpu-power-controller"? This should already help for this warning. Best regards, Krzysztof
Il 15/11/22 16:16, Krzysztof Kozlowski ha scritto: > On 15/11/2022 15:44, AngeloGioacchino Del Regno wrote: > >>>>> Please check and re-submit. >>>>> >>>> >>>> I'm unsure about what I should do about this one. >>>> This is a power-controller, but does *not* need any #power-domain-cells, as it is >>>> standalone and doesn't require being attached to anything. >>> >>> power-domain-cells are for power domain providers, not consumers. The >>> generic binding expect that nodes called power-controller are exactly >>> like that. >>> >>> Solutions could be: >>> 1. Rename the node to something else. I cannot deduct the type of the >>> device based on description. What is "sequence ID" and how is it even >>> closely related to power control? >> >> This uC is mainly controlling DCVS, automagically plays with voltages for >> each ramp up/down step and from what I understand also decides to shut down >> or bring up *power* to "certain clocks" before ungating (CPU related, mainly >> big cluster). >> This also interacts with LMH - setting the LMH part makes it possible to >> later use CPR (otherwise CPR errors out internally and won't start, as it >> requires this controller, SAW and LMH to be set up in order to work). >> >> What I've seen is that without it I can't bring up the big cluster at all, >> not even at minimum frequency, as the HF2PLL (a clock source for that cluster) >> will not power up. >> All it takes is to initialize these params and start the controller, then >> everything goes as it should. >> >> If you're wondering why my explanation may not be particularly satisfying, >> that's because downstream contains practically no information about this >> one, apart from a bunch of lines of code and because this controller is >> just a big black box. >> >>> >>> 2. Narrow the node name in power-domain.yaml which would require changes >>> in multiple DTS and bindings. >>> >>> 3. Do not require power-domain-cells for power-controllers, only for >>> power-domains. >>> >> >> Solutions 2 and 3... well, I don't think that this would be really feasible >> as I envision this being the one and only driver that will ever require >> that kind of thing. >> Also, this programming was later moved to bootloaders and the only SoCs that >> will ever require this are MSM8956/76, MSM8953 and.. I think MSM8952 as well, >> but nothing more. >> >> Even if I can imagine the answer, I'm still tempted to ask: can we eventually >> just name it ramp-controller@xxxx or qcom-rc@xxxx or something "special" like >> that to overcome to this binding issue? > > So maybe "cpu-power-controller"? This should already help for this warning. > Agreed. Thanks for the advice! Sending a v3 asap!
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml new file mode 100644 index 000000000000..67f0bdf7d2da --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/qcom/qcom,msm8976-ramp-controller.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Ramp Controller + +maintainers: + - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> + +description: + The Ramp Controller is used to program the sequence ID for pulse + swallowing, enable sequences and link Sequence IDs (SIDs) for the + CPU cores on some Qualcomm SoCs. + +properties: + compatible: + enum: + - qcom,msm8976-ramp-controller + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + power-controller@b014000 { + compatible = "qcom,msm8976-ramp-controller"; + reg = <0x0b014000 0x68>; + }; +
Document bindings for the Qualcomm Ramp Controller, found on various legacy Qualcomm SoCs. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../qcom/qcom,msm8976-ramp-controller.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm8976-ramp-controller.yaml