mbox series

[00/10] genirq/msi: Treewide cleanup of pointless linux/msi.h includes

Message ID 20221113201935.776707081@linutronix.de
Headers show
Series genirq/msi: Treewide cleanup of pointless linux/msi.h includes | expand

Message

Thomas Gleixner Nov. 13, 2022, 8:33 p.m. UTC 
While working on per device MSI domains I noticed that quite some files
include linux/msi.h just because.

The top level comment in the header file clearly says:

  Regular device drivers have no business with any of these functions....

and actually none of the drivers needs anything from msi.h.

The series is not depending on anything so the individual patches can be
picked up by the relevant maintainers. I'll mop up the leftovers close to
the merge window.

Thanks,

	tglx

Comments

James Smart Nov. 14, 2022, 5:39 a.m. UTC | #1 
On 11/13/2022 12:33 PM, Thomas Gleixner wrote:
> Nothing in this file needs anything from linux/msi.h
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: James Smart <james.smart@broadcom.com>
> Cc: Dick Kennedy <dick.kennedy@broadcom.com>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
> ---
>   drivers/scsi/lpfc/lpfc_init.c |    1 -
>   1 file changed, 1 deletion(-)
> 
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -36,7 +36,6 @@
>   #include <linux/firmware.h>
>   #include <linux/miscdevice.h>
>   #include <linux/percpu.h>
> -#include <linux/msi.h>
>   #include <linux/irq.h>
>   #include <linux/bitops.h>
>   #include <linux/crash_dump.h>
> 

yep - agree.

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james
patchwork-bot+netdevbpf@kernel.org Nov. 15, 2022, 3 a.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 13 Nov 2022 21:33:54 +0100 (CET) you wrote:
> While working on per device MSI domains I noticed that quite some files
> include linux/msi.h just because.
> 
> The top level comment in the header file clearly says:
> 
>   Regular device drivers have no business with any of these functions....
> 
> [...]

Here is the summary with links:
  - [06/10] net: dpaa2: Remove linux/msi.h includes
    https://git.kernel.org/netdev/net-next/c/515e5fb6a95e
  - [07/10] net: nfp: Remove linux/msi.h includes
    https://git.kernel.org/netdev/net-next/c/5fd66a0b3bb4

You are awesome, thank you!