| Message ID | 20221111092457.10546-9-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom-qmp-combo: fix sc8280xp binding (set 3/3) | expand |
On 11/11/2022 12:24, Johan Hovold wrote: > Since the QMP driver split, there is no reason to allocate the > fixed-rate pipe clock structure separately from the driver data. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Note: it would be nice to port these two patches to USB & PCIe QMP PHY drivers.
On Sat, Nov 12, 2022 at 02:17:44PM +0300, Dmitry Baryshkov wrote: > On 11/11/2022 12:24, Johan Hovold wrote: > > Since the QMP driver split, there is no reason to allocate the > > fixed-rate pipe clock structure separately from the driver data. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Note: it would be nice to port these two patches to USB & PCIe QMP PHY > drivers. Already done: https://lore.kernel.org/lkml/20221111094239.11547-1-johan+linaro@kernel.org/ Johan
On 14/11/2022 15:42, Johan Hovold wrote: > On Sat, Nov 12, 2022 at 02:17:44PM +0300, Dmitry Baryshkov wrote: >> On 11/11/2022 12:24, Johan Hovold wrote: >>> Since the QMP driver split, there is no reason to allocate the >>> fixed-rate pipe clock structure separately from the driver data. >>> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>> --- >>> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> >> Note: it would be nice to port these two patches to USB & PCIe QMP PHY >> drivers. > > Already done: > > https://lore.kernel.org/lkml/20221111094239.11547-1-johan+linaro@kernel.org/ Thanks!
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index bfe6d1e59ac7..d513b8924aee 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -897,6 +897,7 @@ struct qmp_combo { unsigned int dp_aux_cfg; struct phy_configure_opts_dp dp_opts; + struct clk_fixed_rate pipe_clk_fixed; struct clk_hw dp_link_hw; struct clk_hw dp_pixel_hw; }; @@ -2251,15 +2252,11 @@ static void phy_clk_release_provider(void *res) */ static int phy_pipe_clk_register(struct qmp_combo *qmp, struct device_node *np) { - struct clk_fixed_rate *fixed; + struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed; struct clk_init_data init = { }; char name[64]; int ret; - fixed = devm_kzalloc(qmp->dev, sizeof(*fixed), GFP_KERNEL); - if (!fixed) - return -ENOMEM; - snprintf(name, sizeof(name), "%s::pipe_clk", dev_name(qmp->dev)); init.name = name; init.ops = &clk_fixed_rate_ops;
Since the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)