| Message ID | 20221111092457.10546-4-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom-qmp-combo: fix sc8280xp binding (set 3/3) | expand |
On 11/11/2022 12:24, Johan Hovold wrote: > The source clock for the reference clock should not be described by the > devicetree and instead this relationship should be modelled in the clock > driver. Do we have a fix for the gcc driver? > > Drop the management of the source clock from the driver for SC8180X and > SC8280XP. Note that support for the former is not yet in mainline. > > Also note that the binding has never been updated to describe the v4 > clocks for SC8180X. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 51a03ac05c91..e6c7cf723b19 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = { > }; > > static const char * const qmp_v4_phy_clk_l[] = { > - "aux", "ref_clk_src", "ref", "com_aux", > + "aux", "ref", "com_aux", > }; > > /* the primary usb3 phy on sm8250 doesn't have a ref clock */
On Sat, Nov 12, 2022 at 02:43:38PM +0300, Dmitry Baryshkov wrote: > On 11/11/2022 12:24, Johan Hovold wrote: > > The source clock for the reference clock should not be described by the > > devicetree and instead this relationship should be modelled in the clock > > driver. > > Do we have a fix for the gcc driver? Bjorn is preparing one, but there's no need to wait for that to be merged in this case (we have a ton of references on CXO, we need to get the binding fixed in 6.2, and some other reasons which Bjorn may be able to share soon). Johan
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index 51a03ac05c91..e6c7cf723b19 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = { }; static const char * const qmp_v4_phy_clk_l[] = { - "aux", "ref_clk_src", "ref", "com_aux", + "aux", "ref", "com_aux", }; /* the primary usb3 phy on sm8250 doesn't have a ref clock */
The source clock for the reference clock should not be described by the devicetree and instead this relationship should be modelled in the clock driver. Drop the management of the source clock from the driver for SC8180X and SC8280XP. Note that support for the former is not yet in mainline. Also note that the binding has never been updated to describe the v4 clocks for SC8180X. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)