diff mbox series

[v2,1/6] pwm: Add a stub for devm_pwmchip_add()

Message ID 20221108142226.63161-2-andriy.shevchenko@linux.intel.com
State Superseded
Headers show
Series pinctrl: intel: Enable PWM optional feature | expand

Commit Message

Andy Shevchenko Nov. 8, 2022, 2:22 p.m. UTC 
devm_pwmchip_add() can be called by a module that optionally
instantiates PWM chip. In case of CONFIG_PWM=n, the compilation
can't be performed. Hence, add a necessary stub.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 include/linux/pwm.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Andy Shevchenko Nov. 10, 2022, 9:54 a.m. UTC | #1 
On Thu, Nov 10, 2022 at 9:07 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Tue, Nov 08, 2022 at 04:22:21PM +0200, Andy Shevchenko wrote:

...

> > +static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *chip)
> > +{
> > +     return -EINVAL;
> > +}
> > +
>
> I'm a bit surprised to see this returning -EINVAL and not -ENOSYS. But
> that's in line with the other stubs, so:

Exactly my thoughts when I created such a change.

> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thank you!
diff mbox series

Patch

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index d70c6e5a839d..bba492eea96c 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -478,6 +478,11 @@  static inline int pwmchip_remove(struct pwm_chip *chip)
 	return -EINVAL;
 }
 
+static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *chip)
+{
+	return -EINVAL;
+}
+
 static inline struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
 						       unsigned int index,
 						       const char *label)