| Message ID | 20221031224728.2607760-1-bvanassche@acm.org |
|---|---|
| Headers | show |
| Series | Call scsi_device_put() from non-atomic context | expand |
On 10/31/22 23:47, Bart Van Assche wrote: > This patch fixes the following smatch warning: > > drivers/scsi/device_handler/scsi_dh_alua.c:1013 alua_rtpg_queue() warn: sleeping in atomic context > > alua_check_vpd() <- disables preempt > -> alua_rtpg_queue() > -> scsi_device_put() > > Cc: Hannes Reinecke <hare@suse.de> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 23 ++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
Bart, > As reported by Dan Carpenter, a recent change may cause > scsi_device_put() to sleep while a few callers remain that call > scsi_device_put() from atomic context. This patch series converts > those callers. Please consider this patch series for the 6.0 kernel. Applied to 6.2/scsi-staging, thanks!
On Mon, 31 Oct 2022 15:47:24 -0700, Bart Van Assche wrote: > As reported by Dan Carpenter, a recent change may cause scsi_device_put() to > sleep while a few callers remain that call scsi_device_put() from atomic > context. This patch series converts those callers. Please consider this patch > series for the 6.0 kernel. > > Thanks, > > [...] Applied to 6.2/scsi-queue, thanks! [1/4] scsi: alua: Move a scsi_device_put() call out of alua_check_vpd() https://git.kernel.org/mkp/scsi/c/0b25e17e9018 [2/4] scsi: alua: Move a scsi_device_put() call out of alua_rtpg_select_sdev() https://git.kernel.org/mkp/scsi/c/379e2554e3d1 [3/4] scsi: bfa: Convert bfad_reset_sdev_bflags() from a macro into a function https://git.kernel.org/mkp/scsi/c/2e5a6c3baccd [4/4] scsi: bfa: Rework bfad_reset_sdev_bflags() https://git.kernel.org/mkp/scsi/c/2e79cf37b15b
Hi Martin, As reported by Dan Carpenter, a recent change may cause scsi_device_put() to sleep while a few callers remain that call scsi_device_put() from atomic context. This patch series converts those callers. Please consider this patch series for the 6.0 kernel. Thanks, Bart. Bart Van Assche (4): scsi: alua: Move a scsi_device_put() call out of alua_check_vpd() scsi: alua: Move a scsi_device_put() call out of alua_rtpg_select_sdev() scsi: bfa: Convert bfad_reset_sdev_bflags() from a macro into a function scsi: bfa: Rework bfad_reset_sdev_bflags() drivers/scsi/bfa/bfad_bsg.c | 29 ++++++++++ drivers/scsi/bfa/bfad_im.h | 26 --------- drivers/scsi/device_handler/scsi_dh_alua.c | 61 ++++++++++++++-------- 3 files changed, 68 insertions(+), 48 deletions(-)