| Message ID | 20221102025930.GA2163061@marvel |
|---|---|
| State | New |
| Headers | show |
| Series | usb: core: pass usb_get_status() 'type' argument to usb_control_msg() | expand |
On Wed, Nov 02, 2022 at 01:58:14PM +0900, Daewoong Kim wrote: > In the commit 2e43f0fe379c > ("usb: core: add a 'type' parameter to usb_get_status()"), the 'type' > parameter was added. It should be passed to usb_control_msg() as an > argument. > > Signed-off-by: Daewoong Kim <daewoong00.kim@gmail.com> > --- > drivers/usb/core/message.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > index 4d59d927ae3e..a81f23d81480 100644 > --- a/drivers/usb/core/message.c > +++ b/drivers/usb/core/message.c > @@ -1150,7 +1150,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, > return -ENOMEM; > > ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), > - USB_REQ_GET_STATUS, USB_DIR_IN | recip, USB_STATUS_TYPE_STANDARD, > + USB_REQ_GET_STATUS, USB_DIR_IN | recip, type, This shows that since 2017, no one has actually used the type field. And there is only one caller that sets it to anything other than this value. But no one even uses that! So let's remove the one caller that is not working, and just leave this as-is and maybe make this even simpler by removing the type field as no one seems to need it. thanks, greg k-h
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 4d59d927ae3e..a81f23d81480 100644 --- a/drivers/usb/core/message.c +++ b/drivers/usb/core/message.c @@ -1150,7 +1150,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, return -ENOMEM; ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), - USB_REQ_GET_STATUS, USB_DIR_IN | recip, USB_STATUS_TYPE_STANDARD, + USB_REQ_GET_STATUS, USB_DIR_IN | recip, type, target, status, length, USB_CTRL_GET_TIMEOUT); switch (ret) {
In the commit 2e43f0fe379c ("usb: core: add a 'type' parameter to usb_get_status()"), the 'type' parameter was added. It should be passed to usb_control_msg() as an argument. Signed-off-by: Daewoong Kim <daewoong00.kim@gmail.com> --- drivers/usb/core/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)