Message ID | 20221102034053.1708845-1-yangyingliang@huawei.com |
---|---|
State | New |
Headers | show |
Series | Documentation: devres: add missing I2C helper | expand |
On 2022/11/2 11:40, Yang Yingliang wrote: > Add missing devm_i2c_add_adapter() to devres.rst. It's introduced by > commit 07740c92ae57 ("i2c: core: add managed function for adding i2c > adapters"). > > Fixes: 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters") > Cc: Yicong Yang <yangyicong@hisilicon.com> I forgot to update the doc, sorry for that. Acked-by: Yicong Yang <yangyicong@hisilicon.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: Wolfram Sang <wsa@kernel.org> > Cc: Jonathan Corbet <corbet@lwn.net> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > Documentation/driver-api/driver-model/devres.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > index 853396d19419..ec97261530da 100644 > --- a/Documentation/driver-api/driver-model/devres.rst > +++ b/Documentation/driver-api/driver-model/devres.rst > @@ -280,6 +280,7 @@ GPIO > > I2C > devm_i2c_new_dummy_device() > + devm_i2c_add_adapter() > > IIO > devm_iio_device_alloc() >
On 2022/11/2 18:38, Andy Shevchenko wrote: > On Wed, Nov 02, 2022 at 11:40:53AM +0800, Yang Yingliang wrote: >> Add missing devm_i2c_add_adapter() to devres.rst. It's introduced by >> commit 07740c92ae57 ("i2c: core: add managed function for adding i2c >> adapters"). > Okay, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> Fixes: 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters") >> Cc: Yicong Yang <yangyicong@hisilicon.com> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: Dmitry Osipenko <digetx@gmail.com> >> Cc: Wolfram Sang <wsa@kernel.org> >> Cc: Jonathan Corbet <corbet@lwn.net> > Next time, please use --cc when sending patches, instead of Cc'ing explicitly > in the body of the message. The rationale is that we have this email in the > archives anyway and every additional byte in the commit message is a waste of > resources (storage, energy and as a result not so environment friendly). OK, thanks for your advice. > >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- >> Documentation/driver-api/driver-model/devres.rst | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst >> index 853396d19419..ec97261530da 100644 >> --- a/Documentation/driver-api/driver-model/devres.rst >> +++ b/Documentation/driver-api/driver-model/devres.rst >> @@ -280,6 +280,7 @@ GPIO >> >> I2C >> devm_i2c_new_dummy_device() >> + devm_i2c_add_adapter() > Perhaps keep this list ordered? OK, I will send a v2 to change it with your review tag. Thanks, Yang >
diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst index 853396d19419..ec97261530da 100644 --- a/Documentation/driver-api/driver-model/devres.rst +++ b/Documentation/driver-api/driver-model/devres.rst @@ -280,6 +280,7 @@ GPIO I2C devm_i2c_new_dummy_device() + devm_i2c_add_adapter() IIO devm_iio_device_alloc()
Add missing devm_i2c_add_adapter() to devres.rst. It's introduced by commit 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters"). Fixes: 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters") Cc: Yicong Yang <yangyicong@hisilicon.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Dmitry Osipenko <digetx@gmail.com> Cc: Wolfram Sang <wsa@kernel.org> Cc: Jonathan Corbet <corbet@lwn.net> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- Documentation/driver-api/driver-model/devres.rst | 1 + 1 file changed, 1 insertion(+)