| Message ID | 20221031222559.199509-1-j.neuschaefer@gmx.net |
|---|---|
| State | Accepted |
| Commit | e8d6e1dd609696128e646a8c747b0f3fb1e02545 |
| Headers | show |
| Series | dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0 | expand |
On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote: > The node name for flash memories has been standardized to "flash@...". > Fix the example in nuvoton,npcm-fiu.txt accordingly. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote: > On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote: > > The node name for flash memories has been standardized to "flash@...". > > Fix the example in nuvoton,npcm-fiu.txt accordingly. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. Documentation/devicetree/bindings/spi/ has a wild mix of - spi: <some vendor>: - spi: dt-bindings: - dt-bindings: spi: "spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2. Jonathan
On Tue, Nov 01, 2022 at 12:30:51AM +0100, Jonathan Neuschäfer wrote: > On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote: > > On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote: > > > The node name for flash memories has been standardized to "flash@...". > > > Fix the example in nuvoton,npcm-fiu.txt accordingly. > > > > Please submit patches using subject lines reflecting the style for the > > subsystem, this makes it easier for people to identify relevant patches. > > Look at what existing commits in the area you're changing are doing and > > make sure your subject lines visually resemble what they're doing. Ah sorry, I missed this line: > > There's no need to resubmit to fix this alone. > > Documentation/devicetree/bindings/spi/ has a wild mix of > > - spi: <some vendor>: > - spi: dt-bindings: > - dt-bindings: spi: > > > "spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2. So, no v2. Jonathan
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt index c63ce4cc0a80f..fb38e96d395fb 100644 --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt @@ -51,7 +51,7 @@ fiu3: spi@c00000000 { clocks = <&clk NPCM7XX_CLK_AHB>; pinctrl-names = "default"; pinctrl-0 = <&spi3_pins>; - spi-nor@0 { + flash@0 { ... }; };
The node name for flash memories has been standardized to "flash@...". Fix the example in nuvoton,npcm-fiu.txt accordingly. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.35.1