mbox series

[v3,00/17] Add Multi Circular Queue Support

Message ID cover.1666288432.git.quic_asutoshd@quicinc.com
Headers show
Series Add Multi Circular Queue Support | expand

Message

Asutosh Das Oct. 20, 2022, 6:03 p.m. UTC 
UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance.
The implementation uses the shared tagging mechanism so that tags are shared
among the hardware queues. The number of hardware queues is configurable.
This series doesn't include the ESI implementation for completion handling.

This implementation has been verified by booting on an emulation platform.
During testing, all low power modes were disabled and it was in HS-G1 mode.

Please take a look and let us know your thoughts.

v2 -> v3:
- Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and ufshcd_config_mcq()
- Use devm_kzalloc() in ufshcd_mcq_init()
- Free memory and resource allocation on error paths
- Corrected typos in code comments

v1 -> v2:
- Added a non MCQ related change to use a function to extrace ufs extended
feature
- Addressed Mani's comments
- Addressed Bart's comments

v1:
- Split the changes
- Addressed Bart's comments
- Addressed Bean's comments

* RFC versions:
v2 -> v3:
- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan

v1 -> v2:
- Enabled host_tagset
- Added queue num configuration support
- Added one more vops to allow vendor provide the wanted MAC
- Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support
- Postponed MCQ initialization and scsi_add_host() to async probe
- Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically)

Asutosh Das (17):
  ufs: core: Probe for ext_iid support
  ufs: core: Optimize duplicate code to read extended feature
  ufs: core: Introduce Multi-circular queue capability
  ufs: core: Defer adding host to scsi if mcq is supported
  ufs: core: mcq: Introduce Multi Circular Queue
  ufs: core: mcq: Configure resource regions
  ufs: core: mcq: Calculate queue depth
  ufs: core: mcq: Allocate memory for mcq mode
  ufs: core: mcq: Configure operation and runtime interface
  ufs: core: mcq: Use shared tags for MCQ mode
  ufs: core: Prepare ufshcd_send_command for mcq
  ufs: core: mcq: Find hardware queue to queue request
  ufs: core: Prepare for completion in mcq
  ufs: mcq: Add completion support of a cqe
  ufs: core: mcq: Add completion support in poll
  ufs: core: mcq: Enable Multi Circular Queue
  ufs: qcom-host: Enable multi circular queue capability

 drivers/ufs/core/Makefile      |   2 +-
 drivers/ufs/core/ufs-mcq.c     | 498 +++++++++++++++++++++++++++++++++++++++++
 drivers/ufs/core/ufshcd-priv.h |  84 ++++++-
 drivers/ufs/core/ufshcd.c      | 353 +++++++++++++++++++++++------
 drivers/ufs/host/ufs-qcom.c    |  49 ++++
 drivers/ufs/host/ufs-qcom.h    |   4 +
 include/ufs/ufs.h              |   6 +
 include/ufs/ufshcd.h           | 136 +++++++++++
 include/ufs/ufshci.h           |  63 ++++++
 9 files changed, 1127 insertions(+), 68 deletions(-)
 create mode 100644 drivers/ufs/core/ufs-mcq.c

Comments

Eddie Huang (黃智傑) Oct. 26, 2022, 9:21 a.m. UTC | #1 
Hi Asutosh,

On Thu, 2022-10-20 at 11:03 -0700, Asutosh Das wrote:
> UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to
> improve storage performance.
> The implementation uses the shared tagging mechanism so that tags are
> shared
> among the hardware queues. The number of hardware queues is
> configurable.
> This series doesn't include the ESI implementation for completion
> handling.
> 
> This implementation has been verified by booting on an emulation
> platform.
> During testing, all low power modes were disabled and it was in HS-G1 
> mode.
> 
> Please take a look and let us know your thoughts.
> 
> v2 -> v3:
> - Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and
> ufshcd_config_mcq()
> - Use devm_kzalloc() in ufshcd_mcq_init()
> - Free memory and resource allocation on error paths
> - Corrected typos in code comments
> 

Thanks the patch and fixing. I port this series with patch [1] on
Mediatek platform and test pass using FIO program

Tested-by: eddie.huang@mediatek.com

[1] https://patchwork.kernel.org/project/linux-scsi/list/?series=688941

Eddie Huang