| Message ID | 20221024132757.3345400-1-sravanhome@gmail.com |
|---|---|
| Headers | show |
| Series | Add support for mp2733 battery charger | expand |
On Mon, Oct 24, 2022 at 4:28 PM Saravanan Sekar <sravanhome@gmail.com> wrote: > > The mfd cell devices name populated on sysfs entry is dynamically derived > from an auto instance which introduced a regression. As a result > mpc2629_charger driver failed to get adc channel because of iio consumer > name mismatch with the sysfs. > > /sys/class/i2c-adapter/i2c-1/mp2629_adc.0.auto/ > /sys/class/i2c-adapter/i2c-1/mp2629_charger.1.auto/ > > Fixes: 466a62d7642f(mfd: core: Make a best effort attempt to match devices) Wrong Fixes tag format, moreover the fixes should be grouped at the beginning of the series, so it will be visible and splittable based on this property.
Hi, On Mon, Oct 24, 2022 at 04:02:21PM +0200, saravanan sekar wrote: > On 24/10/22 15:49, Andy Shevchenko wrote: > > On Mon, Oct 24, 2022 at 4:28 PM Saravanan Sekar <sravanhome@gmail.com> wrote: > > > > > > The mfd cell devices name populated on sysfs entry is dynamically derived > > > from an auto instance which introduced a regression. As a result > > > mpc2629_charger driver failed to get adc channel because of iio consumer > > > name mismatch with the sysfs. > > > > > > /sys/class/i2c-adapter/i2c-1/mp2629_adc.0.auto/ > > > /sys/class/i2c-adapter/i2c-1/mp2629_charger.1.auto/ > > > > > > Fixes: 466a62d7642f(mfd: core: Make a best effort attempt to match devices) > > > > Wrong Fixes tag format, moreover the fixes should be grouped at the > > beginning of the series, so it will be visible and splittable based on > > this property. > > Thanks for quick review Andy, I will correct fixes tag format and group all > the fixes beginning of series in v5. > > Thanks, > Saravanan Also the patch subject has incorrect prefix. It should be "mfd:" instead of "power: supply:". -- Sebastian
changes in v4: - fixed attributes groups review comments in v3 - added new bug fix patches v4-0007 and v4-0008 changes in v3: - fixed dt_binding_check error - fixed spelling usb->USB changes in v2: - fixed spelling - revert back probe to probe_new in mfd driver I do not see a cover letter, but FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> for all patches except DT binding Note, some of the comments regarding spelling were given, I believe you are going to address them in v3. add support for mp2733 Battery charger control driver for Monolithic Power System's MP2733 chipset Saravanan Sekar (8): iio: adc: mp2629: fix wrong comparison of channel mfd: mp2629: Add support for mps mp2733 battery charger iio: adc: mp2629: restrict input voltage mask for mp2629 power: supply: Add support for mp2733 battery charger power: supply: mp2629: Add USB fast charge settings power: supply: fix failed to get iio channel by device name iio: adc: mp2629: fix potential array out of bound access power: supply: fix wrong interpretation of register value .../ABI/testing/sysfs-class-power-mp2629 | 16 ++ drivers/iio/adc/mp2629_adc.c | 8 +- drivers/mfd/mp2629.c | 7 +- drivers/power/supply/mp2629_charger.c | 229 +++++++++++++++--- include/linux/mfd/mp2629.h | 6 + 5 files changed, 228 insertions(+), 38 deletions(-)