| Message ID | 1662480933-12326-1-git-send-email-quic_kriskura@quicinc.com |
|---|---|
| Headers | show |
| Series | Add QCOM SNPS PHY overriding params support | expand |
On 06-09-22, 21:45, Krishna Kurapati wrote: > Added support for overriding tuning parameters in QCOM SNPS PHY > from device tree. This parameter tuning is required to tune the > hs signal on dp/dm lines for electrical compliance to be successful. Applied 1-2 to phy-next, thanks
On Tue, 6 Sep 2022 21:45:30 +0530, Krishna Kurapati wrote: > Added support for overriding tuning parameters in QCOM SNPS PHY > from device tree. This parameter tuning is required to tune the > hs signal on dp/dm lines for electrical compliance to be successful. > > Changes in v13: > Fixed NULL pointer check in driver code. > > [...] Applied, thanks! [3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device commit: 3b08e3fdf056cf30ecb1413d2bcb1353a333024b Best regards,
Added support for overriding tuning parameters in QCOM SNPS PHY from device tree. This parameter tuning is required to tune the hs signal on dp/dm lines for electrical compliance to be successful. Changes in v13: Fixed NULL pointer check in driver code. Changes in v12: Fixed nitpicks in driver code. Changes in v11: Made changes to logs added in phy driver. Fixed nitpicks in code. Changes in v10: Fixed patch headers. changes in v9: Fixed nitpick in driver code. changes in v8: Fixed nitpick in driver code. changes in v7: Fixed nitpick in driver code and dtsi file. changes in v6: Fixed errors in dt-bindings. Fixed nitpick in driver code. changes in v5: Fixed nitpicks in code. Added minimum and maximum for each parameter added in dt-bindings. Added proper suffixes to each parameter as per dtschema. changes in v4: Fixed nitpicks in code. Initial compliance test results showed overshoot in the middle of eye diagram. The current dt values were put in place to correct it and fix overshoot issue. changes in v3: Added support for phy tuning parameters to be represented in bps and corresponding register values to be written are obtained by traversing through data map declared in the driver. changes in v2: Reading the individual fields in each overriding register from device tree. Krishna Kurapati (2): phy: qcom-snps: Add support for overriding phy tuning parameters arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device Sandeep Maheswaram (1): dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 88 +++++++ arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 + drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 255 ++++++++++++++++++++- 3 files changed, 347 insertions(+), 2 deletions(-)