| Message ID | 20221018080418.328614-1-sughosh.ganu@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | thermal: sandbox: Don't build sandbox thermal driver for sandbox64 | expand |
hi, On Tue, 18 Oct 2022 at 13:47, Robert Marko <robert.marko@sartura.hr> wrote: > > > > On Tue, Oct 18, 2022 at 10:04 AM Sughosh Ganu <sughosh.ganu@linaro.org> wrote: >> >> The sandbox64 defconfig does not enable the thermal uclass, but builds >> the thermal sandbox driver. This breaks booting the sandbox64 variant >> with the test device tree. Do not build the driver for the sandbox64 >> variant. > > > Hi, > > It would probably be better to just enable the driver for sandbox64. > It is weird that sandbox64 is not covered by tests as well. Okay. Will send an updated version. -sughosh > > Regards, > Robert >> >> >> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> >> --- >> drivers/thermal/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile >> index 8acc7d20cb..04559dbaf4 100644 >> --- a/drivers/thermal/Makefile >> +++ b/drivers/thermal/Makefile >> @@ -4,7 +4,9 @@ >> # Author: Nitin Garg <nitin.garg@freescale.com> >> >> obj-$(CONFIG_DM_THERMAL) += thermal-uclass.o >> +ifeq ($(CONFIG_SANDBOX64),) >> obj-$(CONFIG_SANDBOX) += thermal_sandbox.o >> +endif >> obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o >> obj-$(CONFIG_IMX_SCU_THERMAL) += imx_scu_thermal.o >> obj-$(CONFIG_TI_DRA7_THERMAL) += ti-bandgap.o >> -- >> 2.34.1 >> > > > -- > Robert Marko > Staff Embedded Linux Engineer > Sartura Ltd. > Lendavska ulica 16a > 10000 Zagreb, Croatia > Email: robert.marko@sartura.hr > Web: www.sartura.hr
hi Simon, On Tue, 18 Oct 2022 at 13:34, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > The sandbox64 defconfig does not enable the thermal uclass, but builds > the thermal sandbox driver. This breaks booting the sandbox64 variant > with the test device tree. Do not build the driver for the sandbox64 > variant. > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > --- > drivers/thermal/Makefile | 2 ++ > 1 file changed, 2 insertions(+) This patch has been superseded by [1]. This patch can be marked as such in patchwork. Thanks. -sughosh [1] - https://patchwork.ozlabs.org/project/uboot/patch/20221018084725.406464-1-sughosh.ganu@linaro.org/
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index 8acc7d20cb..04559dbaf4 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -4,7 +4,9 @@ # Author: Nitin Garg <nitin.garg@freescale.com> obj-$(CONFIG_DM_THERMAL) += thermal-uclass.o +ifeq ($(CONFIG_SANDBOX64),) obj-$(CONFIG_SANDBOX) += thermal_sandbox.o +endif obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o obj-$(CONFIG_IMX_SCU_THERMAL) += imx_scu_thermal.o obj-$(CONFIG_TI_DRA7_THERMAL) += ti-bandgap.o
The sandbox64 defconfig does not enable the thermal uclass, but builds the thermal sandbox driver. This breaks booting the sandbox64 variant with the test device tree. Do not build the driver for the sandbox64 variant. Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> --- drivers/thermal/Makefile | 2 ++ 1 file changed, 2 insertions(+)